Additional Placements

Additional Placements

517k Downloads

[Neoforge 1.21.1] Model Baker Not Functioning

UnusedCactus opened this issue · 14 comments

commented

Minecraft 1.21.1
Neoforge 21.1.172
Additional Placements 2.3.0
modlist.txt

Describe the bug
Possible mod incompatibility causing model baker to not function properly.

To Reproduce
Steps to reproduce the behavior:

  1. Place slab/stair vertically

Expected behavior
The model baker to function properly

Additional context

  1. AT Launcher Console says that the issue is caused by the model baker isn't working due to a null pointer, "p_352386_"
  2. I haven't been able to get this to work with only Additional Placements loaded, so I assume it's a mod incompatibility rather than just a standalone bug.
  3. There's a closed issue with this same bug, however using /reload as recommended only works for vanilla blocks, at least in my case.

latest.log

commented
  1. There's a closed issue with this same bug, however using /reload as recommended only works for vanilla blocks, at least in my case.

/reload only reloads datapack (server resources) so it wouldn't do anything to block models. What you're looking for is F3+R to reload resourcepacks (client resources)

commented
  1. AT Launcher Console says that the issue is caused by the model baker isn't working due to a null pointer, "p_352386_"

I've investigated this and I don't think that's the issue here. It's probably only affecting one model, as only one is shown in the crashlog. I'm still going to add a check to hopefully prevent that from occurring but I doubt it will fix the underlying issue.

commented

ah man my mistake I meant F3+R I will fix it

commented
commented

well I got the keybind wrong again. It's F3+T.

commented

Try again in 2.3.1 and send the game output log if it's still not working

commented

*resin not amber

commented

latest.log
It's not just Create: Dreams 2 Desires blocks, I just used those because they were on the emi page I was on.

Also to note: does not seem to happen to pressure plates, for whatever reason.

Image
(back group: create dreams 2 desires blocks. left group: minecraft weathered copper stairs and prismarine slabs. right group: perfect parity amber brick stairs and slabs (internally minecraft:resin_brick_stairs and minecraft:resin_brick_slab). center: pearfection callery pressure plates on a dreams 2 desires polished cut breccia block)

commented

Still seems to happen. It doesn't seem to say it's due to a null pointer anymore though, just that the model is missing. Also seems to incorrectly make some blocks waterlogged for some reason.

latest.log

commented

seems to only be affecting some Create: Desires 2 Dreams blocks, might want to take it up with them. Perhaps they are doing something weird with their block models?

as for that other issue, that generally only happens if there's a mismatch in blockstate definitions between client and server.

commented

only a few create_d2d blocks showed missing model errors in the console, so only those blocks will be using the "missing model". so what's happening here can only be the result of some sort of mod conflict that bypasses the normal rendering code, and isn't something I can just "fix".
This could occur if something mixins a modded baking method to unbaked models, or a new render method to baked models, which defaults to the cube you see there, and completely and utterly fails to ever even consider the existence of custom block model implementations.

commented

Turning off ModernFix's dynamic resources fixed it. I guess I should send them a bug report about it then.

Image

commented

hmm, I might need to write a special case for that then - as in, hooking in to it. I wonder if they have events for this.

commented

Maybe. It didn't happen with the (older) 1.20.1 versions of the mods, when I had almost the same settings (albeit with the fabric versions instead)