Adorn

Adorn

Mods
10M Downloads

Issue with placing chairs above y=255

True-Galaxy opened this issue · 5 comments

commented

Versions of Minecraft, Fabric and Adorn

  • Adorn: 3.5.0
  • Minecraft: 1.18.2
  • Fabric Loader: 0.14.8
  • Fabric API: 0.57.0

Describe the bug

When trying to place any type of adorn chair at or anywhere above y=255, nothing happens.

To Reproduce

Steps to reproduce the behavior:

  1. Go above y=255
  2. Try to place any type of chair
  3. See error

Expected behavior

For the chair to be placed.

Blue line is y=255
chairbug

commented

Thanks for reporting that, the culprit is this check from the 1.14 era:

Adorn/common/src/main/kotlin/juuxel/adorn/block/ChairBlock.kt

Line 51 in 2aaf036

return if (pos.y < 255 && context.world.getBlockState(pos.up()).canReplace(context))

It's probably copied from vanilla code from that time so it needs fixing for current MC versions.

commented

Is it possible to compile the 1.18.2 version jar with this removed? The new height limit is 319. I tried doing it from the source code but I could not

commented

I just replaced 255 with 319, rebuilt it, and it works perfectly.

Could you post that jar here please, I couldn't figure out how to rebuild it for fabric. I've never compiled code before

commented

I just replaced 255 with 319, rebuilt it, and it works perfectly.