Adorn

Adorn

11M Downloads

Failed to import either FABRIC or FORGE

Xelbayria opened this issue ยท 2 comments

commented

Adorn version

v5.0.1

Minecraft version

1.20.1

Mod loader

Fabric

Mod loader version

0.16.4

Describe the bug

This is applied to FORGE version, too.

I'm a DEV of Every Compat (Wood Good). I was going to import both FABRIC and FORGE version on EveryCompat so it can support the mod for any Wood Mods (Biomes O' Plenty or others). I'm aware Adorn has supports for a few wood mods. They will be made with an exception.

Take a look at the picture I've provided.

To reproduce

If you have a unused Project mod, then you can try import the Adorn from Curseforge Maven or Modrinth Maven.

Both will provide the same error as you can see in the picture.

I tried to import the local mod (download the mod from Curseforge and put it in project's ~/common/mods and got the same error.

Game logs

N/A

Additional context

Image

commented

Hi! This particular issue is probably due to your dev env not using Yarn mappings, which is what Adorn is built on. Other mappings can lead to conflicts.

Additionally, Adorn has no public API, so I can't provide support for using it as a library.

commented

The project is using Architectury-Loom v1.9+. I'll check to see what version of Yarn that Adorn is using on.

EDIT:
it turned out i'm using ParchmentMC mapping, that's probably what caused the conflict

EDIT 2:
@Juuxel

I've done some research on this. I believe the simple way to fix the problem is to adjust the code to match the ParchmentMC's naming convention, so I shouldn't have trouble with importing the mod.

If I recall correctly, there are few mods in FABRIC that use yarn and i had no problem importing it into Every Compat (Wood Good). It's possible. You just need to make the adjustment and compile the mod. You could give it to me or upload one to Curseforge/modrinth. Up to you.

I only need the v5.0.1 seeing that you won't update it and focusing on the newer version, 1.21+

EDIT 3:
See if you can adjust the following methods:

Mapping target name conflicts detected:
  METHODs juuxel/adorn/block/entity/BaseContainerBlockEntity/[getItems, net/minecraft/class_2621/method_11282]()Lnet/minecraft/class_2371; -> getItems
  METHODs juuxel/adorn/block/entity/BaseContainerBlockEntity/[net/minecraft/class_2621/method_11281, setItems](Lnet/minecraft/class_2371;)V -> setItems

first method from the error above

second method from the error above

Hopefully that will save you times to find out where is the problem and I used this: what is the first method via Linkie

to find out which method is it in your class that is causing the problem.

EDIT 4 & FINAL:

Never mind. There is nothing that can be done about the problem. I've research into this and discover it's not possible due to 2 different mappings.