How do we handle "temporary" files made by other mods?
MageInBlack opened this issue ยท 7 comments
Describe the bug
When playing atm10, using this mod instead of simplebackups, it errors while making a backup of the world.
To Reproduce
Steps to reproduce the behavior:
- Download atm10
- Replace simplebackups with advancedbackups
- go into world, try to make a backup. It will fail some of the times trying to backup temporary files it seems.
Expected behavior
Backup to succeed
Versioning (please complete the following information):
- OS: Fedora Linux 41. If need more system info please respond.
- Minecraft Version(s): 1.21.1
- Modloader(s): NeoForge 21.1.114
- Mod Version: 3.7
Additional context
Latest.log can be found here:
https://mclo.gs/UHYxL1z
It is too large for pastebin (1.4MB). To search for advancedbackups error look for "error making backup!" string.
I have no idea if it is a mod's fault to fail to keep temporary files, to fail not to backup temporary files, or the fault of the mods involved. I tried backing up with a command several times to lead to several different errors all centered around temporary files mods make
That's version 3.6.5, according to the logs..? Not 3.7.
This should not be an issue in 3.7.
Sorry, I forgot to update my personal instance with atm10 update. The version is listed as 3.7 because I tested it in a fresh atm10 instance install with freshly updated Advanced Backups just to make sure it is reproducible on the fresh instance. And included latest from my personal instance.
Sorry for the sloppy report. Here is latest.log from the testing instance.
https://mclo.gs/o9pTpVg
Error still shows up, however backing up sometimes works and sometimes when completes it says that backup was complete with errors (backing up tmp files).
https://github.com/HeatherComputer/AdvancedBackups/actions/runs/13092393176
A build is now running, 3.7.1-rc1, which should include another fix for this.
At this point in time it will treat being unable to back up one of these files as an erroring file and continue with the rest of the backup - similar to files the mod was unable to read for any reason.
This behaviour may be adjusted in future.
If you are willing to help me test it, that'd be greatly appreciated.
I'll be pushing the next update due to #108 - my tests have shown this to work, but I'll leave this open until you can confirm it on your end.
Yeah, current behaviour is to log any files that get removed mid backup like that.
In a perfect world, we'd outright skip those temporary files even if they fully exist - but aside from adding them to the blacklist (which can be done right now anyway) i do not know a good way to go about doing that really.
I ran another instance of atm10. It seems to continue with the backup while posting an error in log about tmp files that could not be found and a message in chat to check logs as well as lists failed to back up files.
I assume that is how it is currently intended to work. Did a small backup on test world. Seems to restore just fine