Bug report :
thowtue opened this issue ยท 5 comments
Describe the bug
Compression lvl seems not to compress more at lvl 9 than lvl 4 or 1
To Reproduce
Steps to reproduce the behavior:
I tried different ratio compressions settings (in: config.advancedbackups.zips.compression) and my fullbackup .zip file is around the same size +- 2mb on around 700mb for all backups made.
The config.advancedbackups.chains.compress is set to true as well so i don't understand what is going on.
Expected behavior
Should compress more the .zip files at lvl9 than lvl1
Screenshots
Top one is lvl9 bottom one is lvl1
Versioning :
- OS: Win 10 64bit 16GB ram
- Minecraft Version(s): 1.20.1
- Modloader(s): Fabric
- Mod Version: 3.5.3
Additional context
- launch args : -Xms8G -Xmx12G -Xmn12G
- 70mods loaded
I would assume this is due to the compressibility of the files. There's generally diminishing returns the higher you go with compression, and the files can only compress so much.
Yeah, things are pretty much as jadan said - compression is only so effective, and the compression level affects the goal, it just can't always be acheived.
It's also worth noting that the compression level in the config is (correctly) being passed to java's builtin ZipOutputStream, which handles the actual act of compressing - which does mean that if there is an issue, it's not really one I could fix as it'd be an issue in your build of java.
Allright thank you
My recommendation, to avoid wasting CPU cycles, would be to leave it at 1. You could try 2 or 3 if you really want, but it doesn't appear that it will make very much difference.