Advanced Peripherals

Advanced Peripherals

29M Downloads

InventoryManager getItems() puts unnecessary nbt tags on the returned items

pcfreak9000 opened this issue ยท 0 comments

commented

Descripe

Using InventoryManager#getItems() puts nbt-tags on all the items in the players inventory. This includes simple items like potatoes or cobblestone which in turn become unstackable with "normal" cobblestone or "normal" potatoes.

I haven't tested if the other functions of this block have the same problem.

Expected behaviour: no nbt tags should be added to the items, no nbt tags should be changed.

Steps to reproduce

  1. Enable advanced tooltips (F3+H)
  2. be in survival mode
  3. Setup an advanced computer with an inventory manager
  4. connect the player to the inventory manager with the memory card
  5. put some items into the players inventory like cobblestone
  6. wrap the inventory manager in lua and call getItems() on it
  7. open the players inventory, hover over an item and press ALT to see the nbt-tag. for simple items, "{}" will appear
  8. new cobblestone which is freshly mined can't be stacked with the now modified cobblestone from the inventory, because they dont have same nbt-tag (empty vs none)

Multiplayer?

Yes

Version

0.7.2r (Latest)

Minecraft, Forge and maybe other related mods versions

Forge 36.2.4 Minecraft 1.16.5

Screenshots or Videos

https://pasteboard.co/cwol0oW54dMZ.png https://pasteboard.co/9jdAex5AI0Ic.png

Crashlog/log

No response