[1.18.2-0.7.13a] Various small issues with Advanced Peripherals village pieces
TelepathicGrunt opened this issue · 11 comments
Hello, I am the dev for Repurposed Structures and I like to make mod compat datapacks to add other mod's village pieces to RS's biome variant villages. Page where I keep track of mods to make datapacks with: TelepathicGrunt/RepurposedStructures#113
I was about to do your mod but as I settled down to start making new biome variants of Advanced Peripherals village pieces, I noticed there's a few issues with them. If these issues can be resolved, it will help me out to make sure I do the new variants correctly to match how Advanced Peripherals wants the blocks placed. Here's a list of what I came across:
-
A monitor in the Scientist Plains Village piece is one block too low and causes a flower pot to be floating.
-
The Scientist Savanna Village piece's turtle block and all computer/monitor/speaker blocks will not rotate to face the correct direction if the village piece is rotated (this is usually caused by mod's blocks not overriding the rotate method to return the correct direction property. Has bitten me before too. Example: https://github.com/TelepathicGrunt/Bumblezone/blob/72bd6221216579f3d75d1e6e78e362ff1f7497ab/src/main/java/com/telepathicgrunt/the_bumblezone/blocks/ProperFacingBlock.java#L14 )
-
The Scientist Desert Village piece has a floating potted plant. No idea what block was suppose to be under it.
-
The outside of the Scientist Plains Village piece has a floating computer not being supported by anything. Very odd looking.
Pictures:
Steps to reproduce
To reproduce, spawn into a world and use /locate command to find villages and look for the Advanced Peripherals village pieces in them. Or use Structure Blocks to manually spawn in the pieces (Structure Blocks can also load in with a rotation to test the block rotations as well)
Multiplayer?
No
Version
1.18.2-0.7.13a Advanced Peripherals with Forge 40.0.48
Thank you for the report
Yeah, I really messed these structures up
The Scientist Savanna Village piece's turtle block and all computer/monitor/speaker blocks will not rotate to face the correct direction if the village piece is rotated (this is usually caused by mod's blocks not overriding the rotate method to return the correct direction property. Has bitten me before too. Example: https://github.com/TelepathicGrunt/Bumblezone/blob/72bd6221216579f3d75d1e6e78e362ff1f7497ab/src/main/java/com/telepathicgrunt/the_bumblezone/blocks/ProperFacingBlock.java#L14 )
We use the rotate methods. Also, the computers/monitors/speakers are not from AP, they're from cc.
I'll see why they do not rotate, and I'll fix the structure blocks in the next update 👍🏻
Some of these issues will be fixed in cc-tweaked/CC-Tweaked#1083
And I'll publish an update with some structure fixes soon
Now fixed for both versions.
Computers are still wrong rotated, but this is because of cc-tweaked/CC-Tweaked#1083
Thanks! I’ll begin making the RS-AP compat datapack now to add variations of your buildings to my mod’s villages
checking right now with ap 1.18.2-0.7.15b and found a few ap houses with the entrance stairs facing the wrong direction:
(Also, the one green carpet right in front of the door for the snowy village piece prevents villagers from leaving the house due to no longer able to fit through doorway)
Otherwise, everything looks great!
If you set the stairs to direction east in the jigsaw block, it should fix it. Right now they are north (Edit: south for the snowy village piece is needed. Not east)