Error while calling colony integrator getRequests()
Hiranus opened this issue ยท 6 comments
Descripe
I wrote code that integrates RS with minecolonies request, and it worked quite well
https://pastebin.com/Db8kbsyA
Lately this code crashes when line 72 is executed, which is colonyIntegrator.getRequests() line.
Steps to reproduce
- Wrap Colony Integrator
- Try to execute getRequests()
Multiplayer?
Yes
Version
1.16.5-0.7.8r (Latest 1.16)
Minecraft, Forge and maybe other related mods versions
forge 36.2.34 MC 1.16.5
Screenshots or Videos
Crashlog/log
Full log from server is too big for pastebin, and this is only interesting part.
https://pastebin.com/ZU0r0X75
The issue lies IMHO here:
Change this line to:
if (request != null && request.getRequest() instanceof IDeliverable)
I'll test that, compile it and send the compiled file in here
But thank you for the hint (:
Yeah, I didn't get to test it - setting up a new project to compile is a hassle.
Anyway, to reproduce:
- Build a Stash (from minecolonies) in a colony without a working Journyman.
- Put some items into the Stash.
- A new request is created to move the items from the Stash into the warehouse, but no Journyman will pick it up.
(My script breaks once the Journyman gets killed, falls ill...)
Reason behind this suggestion:
Later request.getRequest() is casted to IDeliverable - which fails:
https://github.com/Seniorendi/AdvancedPeripherals/blob/8bb1196585d874acb4573a3cf187cb8937b2ab22/src/main/java/de/srendi/advancedperipherals/common/addons/computercraft/peripheral/ColonyPeripheral.java#L252
I guess this changed after I made this
Worked as intended, but minecolonies does a lot of changes
Hey
I fixed the bug and added compatibility for minecolonies 1.0.799-ALPHA.
advancedperipherals-1.16.5-0.7.8r.zip
Here is the file is someone want to test it.
Unzip the file before using.