Advanced Peripherals

Advanced Peripherals

30M Downloads

ME and RS bridge refactoring

SirEndii opened this issue ยท 0 comments

commented

This one is actually almost done. I created the two bridges at different times, and stupid young me just ignored that both bridges provide different functions and different features which now really triggers my inner perfectionist

I already "fixed" that a year ago, using an interface which basically prescribes which storage functions these bridges should have.
So this is actually almost done, it just needs some testing

/**
* Implementation for common storage peripheral functions. Used for AE2 {@link de.srendi.advancedperipherals.common.addons.computercraft.peripheral.MeBridgePeripheral}
* and RS {@link de.srendi.advancedperipherals.common.addons.computercraft.peripheral.RsBridgePeripheral}
* <p>
* This ensures that these both bridges use the same methods. This makes it easier to support both in the same script
* In case there is a new mod which adds new ways to store and craft items, this ensures that the new peripheral
* has the same functions as the other ones
* <p>
* Implementation needs to override {@link dan200.computercraft.api.lua.LuaFunction}
*/
public interface IStorageSystemPeripheral {
MethodResult isConnected();
MethodResult isOnline();