Advanced Rocketry

Advanced Rocketry

21M Downloads

Null Blockstate Causing Crashes

GiantLuigi4 opened this issue ยท 2 comments

commented

So, when you try to assemble a space station which has a Botania Flower into a satellite bay, it'll crash the game due to the tile entity's blockState being null TileEntitySpecialFlower.java:173
(I say this because the log points me at this line, which the only thing on that line that can be null is the BlockState)
I decided to check both the code of Botania and Advanced Rocketry, tracked it down to this line:
StorageChunk.java:618
I'd advise directly calling newTile.read(newTile.getBlockState(), nbt); instead of newTile.deserializeNBT(nbt);
Keep in mind, I have not tested this, as my laptop which I am currently on is incapable of running dev envro, elsewise I would pull request it

commented

Ah, I should probably give the log
Here's all that should be relevant, however the lines numbers on Advanced Rocketry didn't line up and I had to go figure out which line was the most likely culprit of the crash myself
Relevant Part Of Log (Pastebin)

Edit: Ah, checking against the 116.5 branch, it lines up: StorageChunk.java:623

commented

This issue is stale because it has been open 60 days with no activity. Is this still an issue? If yes please comment that it still is.