Advanced Rocketry

Advanced Rocketry

21M Downloads

[BUG] Biome scanner crash [1.12.2]

Boscpeing opened this issue ยท 4 comments

commented

Version of Advanced Rocketry

AdvancedRocketry-1.12.2-2.0.0-13.jar

Have you verified this is an issue in the latest unstable build

  • N/A

Version of LibVulpes

LibVulpes-1.12.2-0.4.2-25-universal.jar

Version of Minecraft

1.12.2 forge-14.23.5.2859

Does this occur without other mods installed

  • Y

If Y, what is the MINIMUM set of mods required.
(jei_1.12.2-4.16.1.301.jar)
LibVulpes-1.12.2-0.4.2-25-universal.jar

Crash report or log or visualVM (if applicable)

http://pastebin.com is a good place to put them
crash reports that are put in the issue itself are
hard to read

https://pastebin.com/L8kTS2ty

Description of the problem

Right click biome changer after sending a biome changing satellite into orbit. It then crashes. World crashes if you try and reload it.

commented

this is a nullpointer exception. i mentioned the cause here: #2393
it happens because the biomeid is not initialized. the same biomeid is used in (BiomeHandler.java:22) (thanks for the log). this creates the nullpointerexception.

public class BiomeHandler {

public static void changeBiome(World world, Biome biomeId, BlockPos pos) {
	Chunk chunk = world.getChunkFromBlockCoords(pos);

	Biome biome = world.getBiome(pos);
	
	if(biome == biomeId)
		return;

	if(biome.topBlock != biomeId.topBlock) { // NULLPOINTER EXCEPTION CAUSED HERE
		BlockPos yy = world.getHeight(pos);
		
		while(!world.getBlockState(yy.down()).isOpaqueCube() && yy.getY() > 0)
			yy = yy.down();
		
		if(world.getBlockState(yy.down()) == biome.topBlock)
			world.setBlockState(yy.down(), biomeId.topBlock);
	}

	byte[] biomeArr = chunk.getBiomeArray();
	try {
		biomeArr[(pos.getX() & 15) + (pos.getZ() & 15)*16] = (byte)Biome.getIdForBiome(biomeId);
	} catch (IndexOutOfBoundsException e) {
		e.printStackTrace();
	}

	PacketHandler.sendToNearby(new PacketBiomeIDChange(chunk, world, new HashedBlockPosition(pos)), world.provider.getDimension(), pos, 256);
}

}

commented

This happens to me too

commented

me three

commented

fixed in "Advanced Rocketry - Reworked"
(https://github.com/dercodeKoenig/AdvancedRocketry)