Crash while generating chunks and exploring, "Accessing LegacyRandomSource from multiple threads". Amethyst Golem the culprit?

Question

Crash while generating chunks and exploring, "Accessing LegacyRandomSource from multiple threads". Amethyst Golem the culprit?

wolfsprite opened this issue 3 years ago · 16 comments

wolfsprite commented 3 years ago

Crashed while using Chunky and walking.
Not Enough Crashes pointed towards AdventureZ, and the crash log mentions net.adventurez.entity.AmethystGolemEntity .

Relevant fragment of the logfile below:

Description: Accessing LegacyRandomSource from multiple threads
java.lang.IllegalStateException: Accessing LegacyRandomSource from multiple threads
	at net.minecraft.util.thread.LockHelper.crash(LockHelper:84)
	at net.minecraft.util.math.random.CheckedRandom.next(CheckedRandom:49)
	at net.minecraft.util.math.random.BaseRandom.nextDouble(BaseRandom:62)
	at net.minecraft.util.math.random.Random.nextTriangular(Random:75)
	at net.minecraft.entity.mob.MobEntity.initialize(MobEntity:1075)
	at net.adventurez.entity.AmethystGolemEntity.initialize(AmethystGolemEntity.java:116)
	at net.minecraft.world.gen.feature.GeodeFeature.handler$bca000$generateMixin(GeodeFeature:529)
	at net.minecraft.world.gen.feature.GeodeFeature.generate(GeodeFeature:174)
	at net.minecraft.world.gen.feature.ConfiguredFeature.generate(ConfiguredFeature:537)
	at net.minecraft.world.gen.feature.PlacedFeature.method_39646(PlacedFeature:56)
	at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(Unknown Source)
	at java.util.stream.Streams$StreamBuilderImpl.forEachRemaining(Unknown Source)
	at java.util.stream.ReferencePipeline$Head.forEach(Unknown Source)
	at java.util.stream.ReferencePipeline$7$1.accept(Unknown Source)
	at java.util.stream.Streams$StreamBuilderImpl.forEachRemaining(Unknown Source)
	at java.util.stream.ReferencePipeline$Head.forEach(Unknown Source)
	at java.util.stream.ReferencePipeline$7$1.accept(Unknown Source)
	at java.util.stream.Streams$StreamBuilderImpl.forEachRemaining(Unknown Source)
	at java.util.stream.ReferencePipeline$Head.forEach(Unknown Source)
	at java.util.stream.ReferencePipeline$7$1.accept(Unknown Source)
	at java.util.stream.Streams$StreamBuilderImpl.forEachRemaining(Unknown Source)
	at java.util.stream.ReferencePipeline$Head.forEach(Unknown Source)
	at java.util.stream.ReferencePipeline$7$1.accept(Unknown Source)
	at java.util.stream.Streams$StreamBuilderImpl.forEachRemaining(Unknown Source)
	at java.util.stream.AbstractPipeline.copyInto(Unknown Source)
	at java.util.stream.AbstractPipeline.wrapAndCopyInto(Unknown Source)
	at java.util.stream.ForEachOps$ForEachOp.evaluateSequential(Unknown Source)
	at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(Unknown Source)
	at java.util.stream.AbstractPipeline.evaluate(Unknown Source)
	at java.util.stream.ReferencePipeline.forEach(Unknown Source)
	at net.minecraft.world.gen.feature.PlacedFeature.generate(PlacedFeature:55)
	at net.minecraft.world.gen.feature.PlacedFeature.generate(PlacedFeature:44)
	at net.minecraft.world.gen.chunk.ChunkGenerator.generateFeatures(ChunkGenerator:464)
	at net.minecraft.world.chunk.ChunkStatus.method_20613(ChunkStatus:145)
	at net.minecraft.world.chunk.ChunkStatus.md2fe46c$lambda$runGenerationTask$0$5(ChunkStatus:1601)
	at java.util.concurrent.CompletableFuture$AsyncSupply.run(Unknown Source)
	at java.util.concurrent.CompletableFuture$AsyncSupply.exec(Unknown Source)
	at java.util.concurrent.ForkJoinTask.doExec(Unknown Source)
	at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(Unknown Source)
	at java.util.concurrent.ForkJoinPool.scan(Unknown Source)
	at java.util.concurrent.ForkJoinPool.runWorker(Unknown Source)
	at java.util.concurrent.ForkJoinWorkerThread.run(Unknown Source)

Hippobot · Answer 1 · 2022-06-16T03:13:14.000Z

same issue

Eatham532 · Answer 2 · 2022-06-20T09:30:58.000Z

Same issue. Would be glad if this is fixed soon as I have a server with this mod and it keeps crashing :(

Globox1997 · Answer 3 · 2022-06-20T20:38:20.000Z

Talked with the chunky author, I might know how to fix this.
Reference https://github.com/pop4959/Chunky/blob/master/fabric/src/main/java/org/popcraft/chunky/platform/FabricWorld.java#L51-L53

Eatham532 · Answer 4 · 2022-06-20T20:59:18.000Z

Thanks. So will this be an adventureZ update or a chunky update? (I want to watch the mod to get it when its out)

MatthewRadermacher · Answer 5 · 2022-06-20T21:40:20.000Z

its not chunky related, i am getting this crash while just exploring, unless chunky changes the way chunks load even while not preloading. Just had a server crash where the stack trace pointed to the same error listed here

Globox1997 · Answer 6 · 2022-06-21T09:43:51.000Z

I will try to upload a fix today

Eatham532 · Answer 7 · 2022-06-21T08:28:02.000Z

Chunky makes the amythist golem crash because of the way it generates the world.

Globox1997 · Answer 8 · 2022-06-21T13:21:13.000Z

adventurez-1.4.14.zip
Does this fix the issue? (unpack the zip file)

Eatham532 · Answer 9 · 2022-06-21T22:10:56.000Z

I will test it later today

Eatham532 · Answer 10 · 2022-06-22T07:25:31.000Z

I think. It didn't crash which is good. Just no amethyst golem has spawned yet. What are the spawn rates for the golem?

Globox1997 · Answer 11 · 2022-06-24T13:40:27.000Z

The amethyst golem spawns only one time when the geode gets generated with a certain % chance

MatthewRadermacher · Answer 12 · 2022-06-24T21:50:47.000Z

I can confirm crash still occurs with same problem, just updated my server and am still getting crash when I reenable amethyst golem spawns

MatthewRadermacher · Answer 13 · 2022-06-24T22:11:57.000Z

ill try it later when I have time to bring my server down

Eatham532 · Answer 14 · 2022-06-24T22:10:49.000Z

adventurez-1.4.14.zip
Does this fix the issue? (unpack the zip file)

Globox has a fix if you want to test it. I think it fixes the problem.

Eatham532 · Answer 15 · 2022-06-24T21:40:23.000Z

Ok. If you are in spectator does that make them not spawn. I saw a heap of geodes with nothing in them.

Globox1997 · Answer 16 · 2022-06-27T10:21:48.000Z

Uploaded a new version on cf and I guess this fixed it e042b3e
Reopen if still happening

Share to