Aesthetics

Aesthetics

270k Downloads

null oredict name

Laike-Endaril opened this issue ยท 1 comments

commented

Somehow, the combination of this mod and SuperMartijn642's Core Lib adds a null name to the oredict list. I have no idea what the exact interaction is, so I'm posting on both trackers.

I ran into this when my Set Bonus mod crashed somewhere I didn't expect it to, which ended up being due to the null in the oredict that I'm talking about. I ended up finding it for sure with this code:

                String[] oreDictNames = OreDictionary.getOreNames();
                for (int i = lastCacheOreDictSize; i < oreDictNames.length; i++)
                {
                    System.out.println(oreDictNames[i]);
                    if (Pattern.matches(itemRegex, oreDictNames[i])) matchingOredictIDs.add(i);
                }

Which prints null immediately before the crash which happens on the next line. I'm going to sanitize my inputs better so that Set Bonus doesn't crash from it, but it could cause unknown, indirect compat issues with other mods.

commented

Link to the issue on the other relevant mod's tracker: SuperMartijn642/SuperMartijn642sCoreLib#76