[Bug]: Treasure Reforging Compat doesn't properly work when Treasure Reforging is added to an existing world
VoidLeech opened this issue · 6 comments
Minecraft Version
1.20.1
Mod Version
2.0.16
Forge/Neoforge Version
Forge 47.2.0
What happened?
I had an existing world that used Redux, before Treasure Reforging got released.
Upon adding Treasure Reforging and updating to a Redux version with compat, I checked out the template recipes and noticed these still use enchanted gravitite.
It seems the built-in compat datapack is loaded before the one from Treasure Reforging itself, preventing the built-in pack from overriding it.
Using /datapack disable "builtin/data/gravitite_ingot"
does move the pack behind the one from Treasure Reforging, which works after a /reload
, but this is not persistent upon leaving and rejoining the world. (And doesn't work for me as a workaround, but that isn't an issue with Redux, as I have some other mod in the existing world crashing if items are removed from a tag during /reload
or /datapack disable
)
What was the expected result?
That the Treasure Reforging templates can be crafted with a gravitite ingot instead of the now unobtainable enchanted gravitite.
Steps to Reproduce
- Install Redux & Dependencies
- Create World
- Leave World
- Install Treasure Reforging
- Join World
- Look up recipes for the Treasure Reforging templates.
- Observe incorrect recipes
Log Output (if applicable)
No response
Crash Report (if applicable)
No response
Is this a compatibility issue with another mod?
Treasure Reforging 1.0.0
Additional Context/Information
Incorrect recipe (/w Gravitite Ingot turned on)
/datapack list
after reproduction steps.
Reversing the order of mod installation between Treasure Reforging and Redux, the compat works as expected.
Mentioned by @Lucky-56 in #115 but no proper issue existed yet.
Make sure to confirm these as well before submitting the report:
- The issue persists on the latest version of the mod.
- All version numbers are properly recorded, no instances of ‘latest’
- All details are reported clearly and concisely
- This issue is not a duplicate of another issue
- If the issue is a modpack-related issue, it only occurs with Redux installed, and not without
- If the issue is a modpack-related issue, it has been reported to the modpack devs as well
ahh, yeah hmm
if that’s the issue you’d probably have to move it to the top yeah
unfortunately I don’t know if there is an easy way to do this without making customization harder
luckily, the Aether has an item tag for gravitite, I still need to switch the ingot datapack to replace that instead lol
assuming that treasure reforging uses that tag in its recipes, I should be able to fix this fairly easily as I won’t have to override the recipe at all
I have since found a workaround that works for me.
Via NBTExplorer, I've gone to level.dat > Data > DataPacks > Enabled
, and moved the "builtin/data/gravitite_ingot" string to after the "mod:aether_treasure_reforging" one.
I imagine you could do a similar thing in code?