AgriCraft

AgriCraft

30M Downloads

Model/texture of the sprinkler disappears

MBelhardi opened this issue ยท 10 comments

commented

from time to time it seems, that the model of the sprinkler disapear. (see Screenshot) After reloading minecraft, the model is back.

missing sprinkler model

commented

no, I don't have optifine installed at the moment. I'm using Minecraft 1.10.2. Forge 12.18.3.2316 , and in total 128 mods at the moment.

I think I may have found the problem, because as I took out the resource Packs, the model of the sprinkle were back. It's not the first time I have problems when using agricraft and ressource packs. At the moment I try to find which ressource pack the problem comes with.

commented

Using Optifine?

commented

@MBelhardi Hi! I don't know if you're still experimenting with this. But if it's still a bug you can repeat, could you look at your full logs, and see if there's any complaints like "Load Icon IRON_BLOCK: FAILED!" Or anything else weird on the [agricraft] lines. Uploads are always welcome, but check for any personal information, like directories and names.

Also, if there's a Resource Pack that can be used to consistently cause this, let us know?


@InfinityRaider I recreated the problems to some extent. Did not use OptiFine at all. Added a random resource pack where iron_block.png was replaced with an empty file. To try to cause trouble, you know. Just deleting the image would cause minecraft to switch to the default instead (as designed). Then I just enabled and disabled the pack, or quit and restarted minecraft. I encountered other fun glitches along the way.

Full album: http://imgur.com/a/EMHsZ

Observations:

  • I used a high res resource pack, to mimic the report, but I suspect that it's not important or required.
  • The AgriCraft models don't expect the texture atlas to change, so after they cache a real texture (not missingno), they will not refresh it and so use the wrong data when the pack is changed. Only a full quit will reset this.
  • When switching from corrupted to normal, BaseIcons#IRON_BLOCK finally loads something, and so it caches the normal data. Meanwhile, the CustomWoodType for Acacia has cached the fancy data.
  • In the debugger, if you check the cachedIcon data while switching packs, you'll see that it doesn't change. The reference numbers are the same, even inside the nested arrays. But clearly the models change textures. So something is different or is going on.
  • The inventory item icons for the tank and channel are invisible when the blocks go black in the world.
  • This also means that after switching from corrupted to normal, you can load up JEI and see the other wood types of tanks and such with the normal texture. Only the Acacia items will be invisible.
  • If the sprinkler renderer gets the missingno texture for the iron block icon, it seems to outright disappear. Same thing when the fancy block texture is removed. But it doesn't disappear if it uses the vanilla cache while the fancy pack is enabled. I guess some of the junk data renders and some doesn't? I wonder if maybe when the iron block cache is for a 128 pixel image, and then all the content is 16 pixels wide, that the texture is just too tiny to see on the sprinkler.
  • All of this is interesting, but I also have no idea what happened in MBelhardi's case. My artificially created scenarios seem to look similar. But I can't guess what the original cause was.

Select screen shots supplied:

agricraft resource packs 1
agricraft resource packs 2
agricraft resource packs 5

commented

I feel silly now, the iconCache should indeed listen to resource pack reloads...
nice digging!

commented

Thanks! I agree, I think that would fix a bunch of those visual glitches. The graphics code looks daunting though, in either vanilla or mods.

commented
commented

Okay then. Might want to check it out. The issue it has seems to be serverside.

commented

@darthvader45 Sorry, but I don't know anything about the milestones here. I haven't picked up enough details about them to know what's live and what's accidental.

commented

So I just got this same bug in my dev world. No resource pack involved. It seemed to happen in response to the tree growing off to the side. I'm curious what could have caused it now... o_O
agricraft sprinkler disappears again

commented

Closing since we are moving to 1.16.