Rendering problems for the rotation and bounding boxes of Grates
CodesCubesAndCrashes opened this issue ยท 0 comments
Quick description
After placing a Grate in the world, it will always show the same orientation. Also the bounding box is wrong. (?) Watching things in the debugger, one can see that the game is detecting the player's clicks correctly, and setting the properties with the correct axis. But if you look into the render code for it, you can see that it never uses the axis property, and also never tries to rotate the grate to a non-default angle. So I have ideas for fixes, but I am not familiar with writing renderers, so I don't know if they are the correct way. Thanks to Ashe on Discord for letting us know, and for helping look at the code.
Related issues and searches
- https://github.com/AgriCraft/AgriCraft/blob/master/src/main/java/com/infinityraider/agricraft/renderers/blocks/RenderBlockGrate.java - Specifically,
renderWorldBlockWoodStatic
- #679 - Regression, used to be fixed.
- #359 - Bounding box issue previously.
- https://github.com/AgriCraft/AgriCraft/blob/master/src/main/java/com/infinityraider/agricraft/blocks/BlockGrate.java - The bounds code is missing. Meanwhile, in the matching TE, an older version is found. But those methods are not used by anything anymore.
- 237f492 - Switch over to Rotatable Tile Entities, a feature of InfinityLib that I am unfamiliar with.
Mods and versions used
- Minecraft: 1.10.2
- AgriCraft: 2.0.0a20, plus the in progress a21 code
- InfinityLib: 0.11
Expectations and explanations
- I'm not actually 100% sure what I expected. I never played with grates myself before.
Your environment
- How are you playing?
- Operating System: Windows 10
- Launcher: Intellij/gradlew
- Modpack: none
- What kind of server:
- Singleplayer
- Multiplayer (todo)
- Game Modes:
- Survival (todo)
- Creative
- Save File:
- Brand new save
- Only an existing save