Continued/ongoing conflict between Pam's and Minecraft beet seeds
surio opened this issue · 11 comments
Quick description
My family is playing a custom 1.10.2 pack that includes Agricraft (v 2.0.0-0.11.0-a21) along with Pam's Harvestcraft and Spice of Life. All seeds are acquirable via mutations alone. However, vanilla beets cannot be planted on crop sticks at this point, but only Pam's beet seeds can be planted on sticks (I cheated in a few seeds to test this)
Related issues and searches
There have been some issue threads discussing beetroots and turnips, and they are closed now. But none of them speak about the exact syntax of what was used to bypass the issue of vanilla beetroot being non-plantable.
Mods and versions used
I tested this on a test pack containing most recent agricraft and the Pam's mod used in the mod pack.
- Minecraft: 1.10.2/Forge 12.18.3.2297
- AgriCraft: agricraft-2.0.0-0.11.0-a21
- InfinityLib: infinitylib-0.11.0
- Pam's (Pam's HarvestCraft 1.10.2j)
- Spice of Life (SpiceOfLife-mc1.9.4-1.3.8)
- COFH and the complete Thermal Expansion family of mods plus necessary plugins
- JEI, Journeymap and WAILA + plugins
Steps to replicate the issue
- Planted cropsticks
- Placed a wheat seed on cropstick. Success
- Placed Pam's beet seed on cropstick. Success
- Tried placing vanilla beetroot seed. No success
Expectations and explanations
- To get sugarcane seeds, beetroot and wheat should be planted. Without this step there is no progression
- I would prefer that vanilla beetroot be planteable on cropsticks along with Pam's beetroot also.
Your environment
- How are you playing?
- Operating System: Windows
- Launcher: MultiMC
- Modpack: private
- What kind of server:
- Singleplayer
- Multiplayer
- Game Modes:
- Survival
- Creative
@asiekierka Maybe take a quick peek at this in a dev environment? Might be able to check which line of code might be messing this up.
@surio Have you tried the latest updates to Harvestcraft and Agricraft? Might help a bit.
Why me? No, really. Just curious.
Anyhow, I'm without a computer for the next 20-ish hours and have a large modpack debug task scheduled right after that, so, uh, I'll get to it in a few days.
Sorry, didn't know if any of the others on here are devs. If there are, I'll need some names to ping.
@darthvader45 it is the latest version of agricraft that's being used. Also, this is a vanilla+agricraft interaction issue. If you read my explanation, you'll see that Pam's beets are planteable on crop sticks...
In that case, checking Agricraft code referring to the vanilla beetroot would eventually point out the source of the problem Sorry for the misunderstanding, the phrasing used in the explanation sorta made it sound like a conflict between Harvestcraft and Agricraft.
Is this json present?
https://github.com/AgriCraft/AgriPlants/blob/master/vanilla/plants/beet_plant.json
@InfinityRaider that json is very much present. As a trial, I renamed it to beetroot_plant.json to align with minecraft plant name, and and soon after, a new beet_plant.json was created as well.
My question for you is, are you able to plant vanilla beetroot on your crop sticks in your play testing environment? If so, how? If not, well, there you have it. That's my issue. :)
I think I have solved this issue by extending on the above comment by me.
- Create a new JSON file in /config/vanilla/plants and name it "beetroot_plant.json"
- The contents of the file should be as follows https://pastebin.com/zj1JGUzj (syntax is correct. Tested in my playtest environment)
- The file "beet_plant.json" presently masquerading in /vanilla/plants should be deleted. That file is for Pam's beet and is misleading. The same file is actually present in /config/mod_harvestcraft/plants/ also. At present, this file is recreated in /vanilla/plants/ during gameplay even if the player manually deletes it. But it doesn't allow vanilla beetroot seed planting :/
- With the above setup, vanilla beetroot seeds are planteable on crop sticks, in addition to Pam's beetroot.
Based on the number of times "beetroot json" shows up in the agricraft issues, clearly, this has been a lingering source of annoyance for a few versions into 1.10 gameplay. Please fix this by adding a separate beetroot_plant.json in the vanilla area of the configs using the supplied syntax, in the upcoming release of agricraft.
Thank you.
PS: Might I request keeping this issue "OPEN" to serve as a reminder to the devs for the forthcoming release.
Yes this is a very easy fix, I even offered to change it in the JSON, but at one point there was talk about changing "something" (I do not remember what it was) so that 2 JSON files with the same name would not overwrite each other. not sure what came of it, but that is why it was never changed.
Edit: This is where it was talked about