AgriCraft

AgriCraft

30M Downloads

Seed Analyzer Disconnecting Client

felda opened this issue · 14 comments

commented

agricraft-1.7.10-1.3.1
forge-1.7.10-10.13.3.1387-1.7.10-universal
modpack: Agrarian Skies 2

http://pastebin.com/5HB50MaZ

After entering a seed or stack of seeds into the analyzer it will sometimes disconnect a player or players. Sometimes one player will enter a seed in the analyzer and another player will be disconnected. The server is hosted locally on my computer (dedicated server) and the friend connects over the Internet and it happens to both of us. The fml-server-latest.log shows no errors.

This shows in the latest.log on disconnect, but I'm not sure if it is relevant:
14:04:59] [Server thread/INFO]: felda lost connection: TextComponent{text='Disconnected', siblings=[], style=Style{hasParent=false, color=null, bold=null, italic=null, underlined=null, obfuscated=null, clickEvent=null, hoverEvent=null}}

commented

I subscribe, same issue here, except the server is on a dedicated host in a data-center. Agrarian Skies 1.1.1 to look up which version of AgriCraft it is.

commented

Can you look at the NBT tag of your journal with an NBT-editor?

commented

Do you have a NBT-Editor to advise ? I never used one ¬¬'

commented

Little more information to add to these issues. The NBT load error seems to be coming from the tileentity. I crash while scanning nether wart even if I close the gui.

commented

looking at the code and experimenting I belive the offending code is contained in the following lines

https://github.com/InfinityRaider/AgriCraft/blob/master/src/main/java/com/InfinityRaider/AgriCraft/tileentity/TileEntitySeedAnalyzer.java#L146-L148

This is due to the fact that the error resolves it self if you remove the journal. And the Journal already has the seed type analyzed, so all the previous if statements should not have fired.

commented

Another note this error occurs when there is more than one seed in the journal

commented

I am able to reproduce the bug when I

  1. analyze an invar seed (random pick)
  2. analyze a nether wart
  3. analyze a nether wart (bang)

This only happens on the second scan so looks like something to do with the sorting?

commented

Maybe, thanks for these pointers, I'll try to reproduce this, but first, on what version did you test this (1.3.1 or a self compiled 1.4)?

commented

the 1.3.1 found in Agrarian skies 2

commented

Can anyone confirm if this still happens in 1.4 or not?

commented

I don't reproduce this issue in my modpack. Stranded Strained

commented

I will close this then due to lack of response and since I'm failing to reproduce it as well

commented

Hmm, I'm suspecting there's a journal in the analyzers? I think this issue is caused by the NBT getting corrupted, I'll see if I can figure out why and how to fix it.
I'm not sure if it is related but there was an issue in the code where the analyzer would sync between server and client each tick while analyzing, this has been fixed and I'll wait with investigating this issue until I release 1.4 and this issue still persists (I'll leave this open for now).
For now, removing the journal from the seed analyzer should stop the disconnects from occurring.