AgriCraft

AgriCraft

30M Downloads

Water Tanks Don't Collect Rain From Corosauce's Local Weather & Storms Mod

UndeadZeratul opened this issue ยท 5 comments

commented

http://www.coros.us/mods/weather2

Due to the way this mod overrides vanilla weather behavior, unless it is set to use vanilla's rain mechanic, the water tanks don't fill during the rain, as shown below. Would it be possible to add a hook into this mod? Thanks!

Y u no fill

I'm currently using the following versions:

  • Forge 1448
  • Agricraft 1.3.1
  • CoroUtil 1.1.2
  • Weather 2.3.7
commented

This would take a separate mod interface and special case checks. I recommend against the addition of support for the mod, from a code simplicity standpoint (tanks are complicated enough).

Or, at least, push this way off, until we have a better codebase to work with.

commented

Dedicated seperate addon mod would indeed be better, and because I still haven't had a reply from Corosus I'm not going to give much attention to this anymore, sorry.

commented

Ah, that's fine; I was hoping it'd be something simple like event hooks, but if it's not, no big deal. Thanks for the effort!

commented

Small headsup: I looked at implementing this, however I didn't find a direct and easy way to do it, it might not be there, I might have overlooked it. In any case, I've sent a message to Corosus and I'm awaiting his reply.

commented

Hmm, I was hoping for an easy event hook, but I guess it's not so simple. In the meantime, I can set his mod to use the vanilla weather, and it'll work as expected.