AgriCraft

AgriCraft

30M Downloads

Refactoring hot spots

szuend opened this issue ยท 3 comments

commented

This is a running TODO list of all the places which need some refactorings badly. Prefer editing this post compared to additional comments.

  • Recipes: CustomWood recipe registration has lots of duplicated code
  • CustomWood (MineTweaker3): duplicated code in addShapless and addShaped
  • Seed blacklist and soil whitelist are nearly identical
  • NBTHelper does manual sorting
commented

I don't think the NBTHelper thing is a big deal, due to the way that tag lists are implemented, and the degree of control we need.

commented

Also, we should probably jettison the 1.8 branch seeing as the internals on the main branch have changed so much that the 1.8 port is outdated.

commented

It doesn't hurt having the 1.8 branch around, I'm keeping it for now.