Cant disable login info
tfox83 opened this issue ยท 17 comments
The notification will be removed in the release versions of AgriCraft.
The notification was added as to ensure users knew they were using an alpha version and stability is not guaranteed.
Can you change the color to white, yellow or something more commonly used, FTB ended up just removing this message by hiding all messsages that are in that dark aqua color. Breaking servers and refusing to fix it.
edit: Reading this, I know it sounds like a joke but instead of filtering by the messages defined here, they just strip all messages in one color. ๐
Time to randomize the colors then I suppose...
We just wanted to warn people that AgriCraft isn't finished yet...
If you just added the alpha notice on one line I wouldn't block it, but I cannot have donation links in official FTB packs.
Honestly this is on FTB for including a mod in very early alpha. The first few versions of Beyond even had the build that destroyed framerates.
If they want to include such a message, that's their perogative
Either way he's right. It's the dev's right to include a message supporting any cause they believe in.
(especially removing it in such a lazy and disastorous way)
But Dual, FTB don't support Sponge!
https://i.gyazo.com/thumb/1200/_6b6e64b30ca61dabf88732dd3516b234-png.jpg
And I mean, why would they? Considering Sponge is the only available plugin API for 1.10 for server owners to use with forge modpacks! Breathes Heavily
/rantover
but I cannot have donation links in official FTB packs.
Then don't include the mod, simple as that. If they want to include such a message, that's their perogative, and you shouldn't be fooling around with it (especially removing it in such a lazy and disastorous way), especially when you are making money from putting these mod packs together and potentially depriving mod authors from potential donations. They put in the work to make these mods - they deserve to have donation notices if they so choose.
edit: I hadn't even realised the donations weren't for the mod, but for charitable purposes. Bravo to the authors - I have a lot of time and respect for that.
This isn't just a Sponge issue. You can include color coding that would be passed to in game chat in a shell script you use to handle restarts and other common admin tasks. You could have these color codes in messages passed by a panel. This is a lazy hack to remove something that shouldn't be removed in the first place. I understand where FTB is coming from with having notification spam, as a modpack developer you always want the ability to disable that, but if you don't have that ability in a config file, the solution isn't to break things for other people by using some ugly hack to disable all chat in a certain color.
It's not about providing Sponge support. It's about breaking expected behavior for whatever mod, script, or plugin API wants to use specific chat formatting.
I'm willing to add a config option that removes the links from the alpha warnings on the condition that you promise not to remove alternate one-line alpha warnings.
The new config option will not be enabled by default however, and it will be up to you to set it in your packs.
If you had specified in the original issue that your problem was with the links in the warnings, the majority of this drama likely could have been avoided, given that I understand there exist possible legal issues regarding donation links (be they charitable or not).
2.0.0a15 should be out by Monday.
Thank you for looking into this again. As of the last Beyond public beta we redid our regex to properly hide repeated incoming chat messages during login. This fix will solve the issue that sponge server owners were having with color codes.
Since Agricraft is not the only alpha mod in this pack we have decided its only fair to notify the players in a less abrasive way that some mods are still in an alpha state and contain bugs, and how/where to submit issues, either via on the main menu of the pack or a notification before the menu screen. We are actively working on this solution now and will have it in the next update.
Things have been put in place to prevent mods in an alpha state to release in a future FTB pack, including reaching out to the developers directly when using an alpha mod during development. I think we can all agree that since the start of MC 1.8 stability is a bit less in any major modpack and we know over time this will change, just as it did with MC 1.7. We actively update Beyond weekly and fix as many bugs as we possibly can, and make sure that mod bugs are reported in the correct places.
"This fix will solve the issue that sponge server owners were having with color codes."
For future reference your filtering of all chat following a certain color code has nothing to do with Sponge. I reported the issue first and do not use sponge. Chat colors are vanilla functionality but you already knew that because I even provided an example vanilla command to show you that in my initial report and offered to fix only the parts you had problems with.
I even quoted this github issue but didn't mention that you created it in hopes of shaming you into silently fixing the lazy hack without calling public attention to that fact that you ignored the mod author's wishes to inform users that the mod was in alpha and may have a lot of problems. I tried to help you just fix the mistake.
Please don't lie just to save face afterwards because it's insulting to those of us that tried earnestly to help.
Does Curse/FTB make money off of their modpacks?
That just seems so greedy to ask for the mod author to remove the donation link if they do.
Yes they do, through ad revenue. And Curse is so kind as to share some of that revenue with the modders.
Agricraft is not and will never be developped with the intention to generate revenue. As a result there will never be donation links. The donation links which RlonRyan added to the alpha warnings are just to add a hint of humor to them.
However this is enough off topic for this issue, if you wish to discuss revenue streams in minecraft modding, I prefer you do that on reddit or the FTB forums, thank you.
An alpha with the modification mentioned earlier has been released, and as such this issue is drawn to a close.
Exit, Stage Right.