Iron nuggets hijacking recipe and not working in crafting
Liiw opened this issue ยท 22 comments
Hello!
I'm using Agricraft on a 1.10.2 Spongeforge server. I also have Unidict installed for unifying ore processing. I am experiencing an issue with iron nuggets from AgriCraft. Whenever I try to craft iron nuggets, I am forcefully given Agricraft nuggets even though before taking them out of the output slot, nuggets from Immersive Engineering are displayed. When trying to use Agricraft nuggets in any of the recipes, I am unable to take the crafting result from the right slot. I even tried to forcefully remove the iron nugget recipe and adding one that provides nuggets from Immersive Engineering. Only workaround for now seems to be using the nugget cast from Tinkers Construct.
Can confirm, loaded up a test SP world and tried forming an ingot from Agricraft nuggets- it worked. I also tried creating iron nuggets from an ingot and was given Immersive Engineering nuggets. I then crafted an OpenComputers cable using Agricraft nuggets and it also worked. How could this issue be fixed?
I have the same issue on server I get agricraft nuggets that I can do nothing with. Single player everything works as expected. However I do not use spongeforge
Based on the fact that this does not happen on a SP world, it would seem so. It will take me some time, but I think it's possible to test SMP. I will report my findings as soon as possible.
I think the real bug here is that AgriCraft still adds it's own nuggets, when the JSON files remove the need for them in the first place. All we have to do is rework the loader to allow for conditional loading of certain files, and then the resource plants will only be loaded when the resource actually exists on the server. In such a matter we can get away with making someone else do the work for the nugget items.
I think if i remember correctly that this is/was the case, if other nuggets were already detected agricraft did not add any.
I just encountered this issue, is there a fix yet? E.g forcing substatrum nuggets to be the main one in Unidict or something?
Obviously this has been discussed, but I'm also having this problem in multiplayer worlds. I'm on Minecraft 1.10.2 using agricraft-2.0.0-0.10.0-a19.jar
with the modpack listed here.
I've also tried using the Forge Lexicon to convert the nuggets into different nuggets, and that didn't work. I could place the nuggets in the book, but I wasn't able to remove the items.
I was, however, able to drop the nuggets into a Tinker's Construct smeltery and have them melt normally. Casting into a nugget cast does produce usable (i.e., non-Agricraft) nuggets.
@andrewminer Just a quick question. Do you have SpongeForge installed on the server?
@Liiw โ No, I don't have SpongeForge on my server.
I have the same issue, cannot use nuggets to craft OpenComputers things and cannot cast them in Tinker's Construct.
I'm using agricraft-2.0.0-0.10.0-a19.jar
and forge1.10.2-12.18.3.2185
A list of mods:
AbyssalCraft-1.10.2-1.9.4-pre-4.jar
Advanced-Machines-60.0.4.jar
agricraft-2.0.0-0.10.0-a19.jar
ArchitectureCraft-1.7.0-mc1.10.2.jar
bdlib-1.12.3.22-mc1.10.2.jar
BiblioCraft[v2.2.4][MC1.10.2].jar
Bloodmoon-MC1.10.2-1.5.1.jar
Chameleon-1.10.2-2.3.0.jar
CodeChickenLib-1.10.2-2.5.9.283-universal.jar
Currency-1.10.2-1.4.3-Beta.jar
CustomMainMenu-MC1.10.2-2.0.5.jar
forestry_1.10.2-5.2.17.388.jar
ForgeMultipart-1.10.2-2.0.0.38-universal.jar
generators-0.9.20.23-mc1.10.2.jar
industrialcraft-2-2.6.252-ex110.jar
infinitylib-0.11.0.jar
jei_1.10.2-3.14.7.419.jar
JustEnoughResources-1.10.2-0.5.8.98.jar
Mantle-1.10.2-1.1.5.jar
MrTJPCore-1.10.2-2.0.1.20-universal.jar
OpenComputers-MC1.10.2-1.6.2.7.jar
OreDictionaryConverter-1.9.1.jar
PackingTape-1.10.2-0.6.0.jar
ProjectRed-1.10.2-4.8.4.49-Base.jar
ProjectRed-1.10.2-4.8.4.49-fabrication.jar
ProjectRed-1.10.2-4.8.4.49-integration.jar
ProjectRed-1.10.2-4.8.4.49-lighting.jar
ProjectRed-1.10.2-4.8.4.49-mechanical.jar
ProjectRed-1.10.2-4.8.4.49-world.jar
redstonepaste-mc1.9.4-1.7.4.jar
signpost-1.10.2-1.05.2.jar
Souls-1.10.2-1.1.3.jar
StorageBoats-1.7.jar
StorageDrawers-1.10.2-3.7.9.jar
TConstruct-1.10.2-2.6.5.jar
teletoro-1.10.2-20.1.jar
thutcore-3.19.1.jar
thuttech-4.0.12.jar
ToughAsNails-1.9.4-1.1.1.jar
WanionLib-1.10.2-1.3.jar
Waystones_1.10.2-2.0.13.jar
It's really frustrating that this is being dismissed as "just a spongeforge issue" when there are people here who have stated they do not have spongeforge and it's happening to them too.
Is there any fix or workaround for this that doesn't involve having to pour nugget by nugget from a smeltery faucet??
@xAlicatt Restarting, the game + server, that fixed it until it .. appeared again, but I moved to 1.12.2 at this point.. so All i can do is hope for it to be fixed in the 1.12 release
EDIT: And indeed I did not use Spongeforge either, I used up to date normal forge.
@DeadSix27 I think moving to 1.12 is very premature, but to each his/her own I spose. We are getting close to ready to move to 1.11 (just waiting on ender io), but 1.12 is still very early stages in both Forge and available mods.
I've tried restarting, i've tried using auto-ore dictionary converter and forge lexicon to force nuggets to the preferred mod. Nothing works. Agricraft forces its borked ingots onto you whether you like it or not. The only workaround i have found is pouring nuggets one by one through tinkers.
@xAlicatt I had massive performance issues on 1.10, not sure what mod(-combination) caused it.. but ye.. everything works surprisingly smoother in 1.12 for me.. while I do miss EnderIO and hope they ditch 1.11 for 1.12 like a few others do.. I relied on EnderIO so much in the past time to try without :)
Update and fix
The cause of this bug was that OreDictionary#registerOre
was being called in a client side only method, meaning that AgriCraft nuggets would be missing from the ore dictionary of a dedicated server. The recipes would show up correctly in the GUI, and they would work fine in single player, but the server would veto any attempts to use them.
The bug had been hidden because the override method in AgriCraft's code didn't have the client side only label. But since the original has the @SideOnly(Side.CLIENT)
annotation, then the override will also receive the effect.
I've committed a patch for this, that makes sure the ore dictionary registration gets called on the server too. I've also added a few other commits that improve or fix nugget related things.
I tested them out by putting the re-obfuscated jar into a fresh copy of the FTB Beyond (v1.11.0, MC 1.10.2) modpack. First in single player, and then in a local dedicated server.
- I crafted ingots using only AgriCraft nuggets and then also in a mixture of other ones.
- I repeated that for all of the materials, except for Osmium since I didn't have Mekanism installed.
- I looked in JEI at the usage recipes for the AgriCraft nuggets, and I didn't see any obvious weirdness.
- I crafted some parts from OpenComputers using AgriCraft's iron nuggets.
If anyone can describe their bug experiences more specifically, then I can test those too. I looked at the reports here, and also in the other issues (like 137, 773, 783, 1043, and 1066), but more specific examples are welcome.
Screenshots from testing the patch
I'll test it ASAP
Edit:
I've just realized that I don't know how to build this, it's getting a hell of dependencies
@sigmasoldi3r Which part is it stuck on? A fresh install sometimes trips me up. For example, I tend to forget to do git submodule init
. Are you trying to get it into an IDE, or just do gradlew reobfJar
?