AgriCraft

AgriCraft

30M Downloads

Crash when trying to craft bowl

Dilnu opened this issue ยท 13 comments

commented

Hi, I'm running 1.10.2 Forge 12.8.3.2297 with Agricraft 2.0.0-0.10.0-a17

I tried to disable irrigation in the config and I get this crash log when trying to craft the vanilla bowl recipe with three planks.
https://jpst.it/-6yj

commented

That, uh, that might not actually be our fault...

That is a really non-specific crash report.

@TehNut, uh, could you take a look at that log please?

commented

Useless logs! My favorite kind of log.

Not too sure what could be causing that. There's really nothing in that method that could NPE since all if it gets checked.

commented

Yeah...

Perhaps a list of all the mods you have installed would help?

commented

From the log it looks like it's a minimal environment which makes this even harder to debug.

UCHIJAAAA mcp{9.19} [Minecraft Coder Pack] (minecraft.jar) 
UCHIJAAAA FML{8.0.99.99} [Forge Mod Loader] (forge-1.10.2-12.18.3.2297.jar) 
UCHIJAAAA Forge{12.18.3.2297} [Minecraft Forge] (forge-1.10.2-12.18.3.2297.jar) 
UCHIJAAAA infinitylib{1.10.2-0.10.0} [InfinityLib] (infinitylib-0.10.0.jar) 
UCHIJAAAA agricraft{2.0.0-0.10.0-a17} [AgriCraft] (agricraft-2.0.0-0.10.0-a17.jar) 
commented

Oh, I missed that, sorry...

But with that environment, I'm not even sure this error makes any sense...

I almost wonder if we've stumbled across some form of Forge error...

I can't tell what function that is to look at the bytecode, and I can't de-compile minecraft to look at the code that way... so...

commented

a => func_180453_a => renderItemOverlayIntoGUI

commented

How'd you figure that out?

commented

MCPBot on IRC.

thing

There is also a bot with an MCP querying function on the Modded Minecraft (/r/feedthebeast) discord.

commented

Huh...

commented

Neat!

commented

Based on that def though this definitely feels like something forge should be picking up on, or at least providing a better error message. Then again there are a lot of minecraft functions to hook into so...

commented

Oh, sorry I can explain more precisely what I think is happening. I think there's an error that occurs because the recipe for the irrigation channel isn't fully unregistered. So it tries to craft the irrigation channel but fails because the item doesn't exist. The bug only occurs when irrigation is disabled in config.

commented

@Dilnu that makes sense, thank you very much!

Although, forge should probably add a better check for this...