AgriCraft

AgriCraft

30M Downloads

Crash on server startup with version a18

DeadSix27 opened this issue ยท 8 comments

commented

Stacktrace: https://gist.github.com/DeadSix27/953d5baaed09426761c3dceb1372d97e
Say if you need more than that.

commented

same on client.

commented

Great. Guess that release was premature... I suppose AgriCraft is still in alpha so, it's to be expected. I don't know if I should pull the release since I don't know if I have time to prep a new release soon... Oh well...

commented

@RlonRyan it's alright I know what to expect when downloading alpha builds and the only way I can think of how you could prevent these problems is a test-group/test phase where you spread the file outside of curseforge, but then again, why not just spread it on curseforge and receive issues like this...

*cough* not to mention even the recently released extrautilties update crashes, despite being a release-type upload and not an alpha soo.. ye, stuff happends that's what issue trackers are for :p

commented

Well, uh, this is problematic...

Caught exception from AgriCraft (agricraft)
java.lang.NullPointerException
at com.infinityraider.agricraft.core.JsonPlant.convertProductJSON(JsonPlant.java:215) ~[JsonPlant.class:?]

This error shouldn't be occurring... meaning this is a deeply rooted issue...

commented

I see... the converter can fail and return a null value even after the validation step... Time to rewrite AgriCore!

commented

@RlonRyan DId I open pandoras box? Also, you validate json but the json converter still fails on valid json? Strange, All That you could do is Catch the exception tho, no? (Mind you I never looked much into your code, at all)

commented

Nah, it's not that bad of a fix, it just looks deeply integrated.

commented

net.minecraftforge.fml.common.LoaderExceptionModCrash: Caught exception from AgriCraft (agricraft) Caused by: java.lang.NoSuchFieldError: DEFAULT_PLANT_ICON

Solved by using version a17.