Feature Requests for Rebirth of the Night
CalaMariGold opened this issue · 7 comments
Hello, I'm the creator of Rebirth of the Night (1.12.2) and we'd love to use this mod as an alternative to ActualMusic. The work you've done here is great so far, but there are a handful of features that would make this perfect. Please let me know if you have any questions about any of them.
These feature requests are ordered in terms of importance. The top being the most important.
- Manual Prioritizing
Ability to set a specific trigger with a specific priority.
Example:
event.rain[Priority:4]=RainSong
secondarytag.moutain[Priority:5]=MountainSong
In that example, if the player is in a mountain biome and it's raining, the rain song would play since its priority is closer to 1.
OR
A simpler way to accomplish this is if the ambience.properties file reads from top to bottom in order of priority, so songs at the top would always have priority over songs under it.
- Debug log
A config option to enable debugging to the log for what song is currently playing and the trigger for it. Possibly another config option to output it to chat.
- Trigger Combinations
Allow the possibility to combine multiple triggers. For example, secondarytag.moutain-event.rain=MountainRainSong
would only play while it is raining and the player is in a mountain biome.
- More triggers
ForgeLoad
Cutoff and Start: song[start:1:30]
would make the song start at 1 min 30 sec. Same syntax for cutoff
Snowing and thunderstorming triggers
Sunset and Sunrise triggers (alternatively, time-based triggers where we could define a time frame ourselves)
Trigger for Nyx lunar events (blood moon, star shower, harvest moon, full moon)
Home trigger (when the player is X blocks near a bed that is set as their spawn point)
- Ambience vs Music
A clear separation of "music" and "ambience". Basically, 2 config files and they both can play at the same time. The only difference is that one would be used for playing ambient sound effects while music is playing from the other file. The ambience config should have a "chance" config option that indicates the chance that a sound effect would play.
Just found out there is a debug section in the F3 menu outputting what song is currently playing. Scratch the debug feature request :)
Hi, thanks for the suggestions 🤗 so.
1- Manual Prioritizing: this unfortunately ins't possible to create, because the way the mod was created, to make that this would have to be done thinking on that since the beggining or rewrite the mod core and the events from scratch that is a lot of work =/
2- Trigger Combinations: this is planned to a future update already.
3- More Triggers: cutoff isn't possible, the music java player that the ambience is using is so simple that there is only two functions (the play and stop functions)
snowing I can check if its possible
thunderstorm I think it's possible
sunset and sunrise can be added
trigger events from other mods is complicated, to make that I should add the Nyx as a dependency mod, so everyone must have it installed to be able to use the ambience too, I don't like to force people to install other mods to be able to use my mod
the home trigger won't work very well, because it will work in a radius and if your bed is in the corner of your house it will trigger even outside, because of that I've created the possibility to make custom areas to play musics inside
4 - Ambience vs Music: this can be done, but the problem is, when the second should be played? For that case what I make is create an area and put a ambience sound, and the other sounds I use the speaker block to play using some redstone logic
4 - The ambience config should have a "chance" config option that indicates the chance that a sound effect would play. So, for example, if you're underground, there could be a 10% chance every X ticks that a random cave ambience sound would play, similar to vanilla cave ambience. It would be even better if you could hook into vanilla ambience, so that vanilla ambience does not overlap with the mod ambience.
As for the others that you said you could do, do you have an estimated release date for the trigger combinatioins and weather triggers?
@viniciusgf2 Is it possible that you could add a ForgeLoad trigger for when Minecraft first starts up?
do you want to play a song as the game launches? and after that it return to the main menu song?