Mouse Wheelie prevents manual render updates via updateBlock from working
natanfudge opened this issue · 5 comments
Version
mousewheelie-1.3.8+1.15-pre5 on Minecraft 1.15-pre6
Describe the bug
I develop https://github.com/natanfudge/SpatialCrafting, which has a "hologram" multiblock structure. You can hold the Y key to minimize holograms. This works by checking if the hotkey is held, and sending a render update at the start of the press. However, when Mouse Wheelie is installed, blocks are not updated when MinecraftClient.worldRenderer.updateBlock() is called, and instead a render update must come from another source like a block placement for the holograms to update.
To Reproduce
- Install Spatial Crafting and Mouse Wheelie.
- Place a 2x2 crafter with a Wood-carved Crafter.
- Hold Y.
- Notice how while the bounding box shrinks, the models themselves don't.
- Try placing a block with the key still held. The holograms are updated.
- Remove Mouse Wheelie.
- Do the same thing, but notice how the holograms shrink and unshrink immediately just by pressing the hotkey, without the need to do anything.
Now that I think about, it could be that mouse wheelie/amecs is preventing the initial press from working, while the held press is working fine. Here's the logic I use to determine if a press is the "initial" press.
I just noticed that.
Mojang improved their API so you can now handle key down events correctly. This was previously only possible through mixins which are one part of Amecs API. Amces ListeningKeybinding
will be deprecated because you can now achieve the same with vanilla logic.
Finally I can remove some mixin parts which are now not neccessary anymore.