Gradle files (such as gradlew, gradlew.bat, and the gradle wrapper) are missing
Jonathing opened this issue ยท 13 comments
These files are essential to allowing others to contribute to code with setupDecompWorkspace and build. Without these files, people will have to manually install the Gradle wrapper themselves, which is a pain.
Is it even "legal" to add these files? Galacticraft doesn't add these, either
@katzenpapst yes it is. All mod creators use them and must be added to the repo for others to collaborate. Just because GalactiCraft doesn't add them doesn't mean everyone else doesn't add them as well.
EDIT: sorry If I sounded a bit harsh in that.
@katzenpapst One more thing, I've noticed that you have local API files in your lib or libs folder if I am correct? Would you mind either giving out the apis that you have used in the project in a README.md or removing /lib and /libs from the .gitignore file (if necessary, of course. If it can build without them then it's fine)? Thanks.
There are just the galacticraft-dev jars. I'm probably doing it wrong, but I'm not sure how to do it the "right" way
@katzenpapst You have imported the galacticraft-dev jars alright, but do you mind telling me what version of galacticraft you are using to create your addon, as the .gitignore also ignores the /libs folder which I need to build your addon (because it contains the galacticraft-dev jars as you had stated).
@katzenpapst awsome. can you also add in the libs folder? that has the dev jars and it's needed to build the thing