Ancient Spellcraft

Ancient Spellcraft

7M Downloads

[Bug] Words of Unbinding randomly removes upgrade while holding a off-hand upgrade scroll

KnightCa opened this issue ยท 1 comments

commented

Is there an existing issue for this?

  • I have searched the existing issues

Observed behaviour

While casting Words of Unbinding while holding the Sage Tome Sentience Upgrade in the off-hand, a random upgrade is removed (in this case it was a Attunement upgrade removed).

In addition, if a Attunement upgrade is removed, the Sage Tome continues to have the same number of spells listed in it until a Attunement upgrade is re-applied to it.

If you then add a Attunement upgrade back to the Sage Tome, it fails to use up the Attunement upgrade scroll.

image

Expected behaviour

According to the github "Removes a random wand upgrade from the wand which casts this spell. You can control which upgrade is being removed if you hold the upgrade's scroll in your offhand."

I expected Words of Unbinding to remove the offhand upgrade from the Sage Tome.

If a Attunement upgrade is removed, I expected the number of assigned spells to be reduced as well.

Steps to reproduce

  1. Join a Server
  2. Add the following Wand Upgrades: 3 Attunement, 2 Sage Tome Sentience, 2 Blast
  3. While holding a Sage Tome Sentience upgrade scroll in offhand, cast Words of Unbinding
  4. Notice which Upgrade is removed

It's random which upgrade is removes, so repeat to see the randomness if necessary.

Crashlog

No response

Environment (Singleplayer/Server, etc.)

Issue present on both sides

Mod version

1.5.10

Forge version

1.12.2-forge-14.23.5.2860

Other mods

No response

commented

If a Attunement upgrade is removed, I expected the number of assigned spells to be reduced as well.

fixed by 15e7ba6