Ancient Spellcraft

Ancient Spellcraft

Mods
7M Downloads

[Bug] Golden Scroll holder no longer effects Wands while holding a Condensing Wand Upgrade

KnightCa opened this issue ยท 3 comments

commented

Is there an existing issue for this?

  • I have searched the existing issues

Observed behaviour

While holding a Condensing Wand Upgrade, the Golden Scroll belt bauble fails to restore any mana to Wands over time (whether held Wand, hotbar, inventory, or off-hand).

It does work properly with the Blast, Cooldown, Duration, Range upgrade.

As expected, Siphon upgrade has no effect when used with the Golden Scroll belt bauble.

Expected behaviour

I expected the Golden Scroll belt bauble to give the Condensing Upgrades effects to any Wand in inventory, hotbar, or off-hand.

image

Steps to reproduce

  1. Join a Server
  2. Use mana from a Wand without condensing, so its not at full charge
  3. Notice the lack of mana increase
  4. Add a Condensing Wand Upgrade to a Golden Scroll belt bauble (you can do this by holding the wand upgrade scroll in your off-hand hand, then right-clicking the Golden Scroll bauble in your main hand)
  5. Put the Golden Scroll on your belt bauble slot
  6. Notice the lack of mana regeneration

Crashlog

No response

Environment (Singleplayer/Server, etc.)

Issue present on both sides

Mod version

1.5.11-PreRelease-54bfadc

Forge version

1.12.2-forge-14.23.5.2860

Other mods

Related to Issue #17

commented

This issue is potentially a duplicate of one of the following issues:

  • [#202] [Bug] Words of Unbinding randomly removes upgrade while holding a off-hand upgrade scroll (53% match)
  • [#175] [Bug] Conduit spell fails to identify a Sage tome or a Spell Blade (with mana storage) as a valid Wand (50.54% match)
commented

@WinDanesz Tested this with the latest release of Ancient Spellcraft (ancientspellcraft-1.12.2-1.5.11-PreRelease-4f214c5.jar) and its working closer to correctly. Here is where it still has issues.

Issue 1: The condensing upgrade, once added to the Golden Scroll and placed in the Bauble slot.. only effects a Wand that has been used to cast a spell after the condensing upgrade got added to the Golden Scroll.

Issue 2: If multiple Wands are on the hotbar and have cast spells after the condensing upgrade was added to the Golden Scroll, only the last Wand used will recharge.

Issue 3: The Wand must remain on the hotbar (does not function for off-hand or inventory Wands) and not be removed from the hotbar (even if later put back on the hotbar).

Example how to replicate:

  1. Have 2 Wands on the hotbar without full mana.
  2. Add a condensing upgrade to the Golden Scroll and put it in the Bauble slot.
  3. Notice that the mana does not recharge on either Wand (issue 1)
  4. Cast a spell from the 1st Wand on the hotbar.
  5. Notice that the 1st Wand starts to recharge.
  6. Cast a spell from the 2nd Wand on the hotbar.
  7. Notice that the 2nd Wand starts to recharge, but the 1st Wand stops recharging (issue 2)
  8. Move the 2nd Wand to off-hand or Inventory (not on hotbar)
  9. Notice the 2nd Wand also stops recharging (issue 3)
  10. Move the 2nd Wand back to the hotbar
  11. Notice neither Wand is recharging
  12. Cast a spell from either Wand
  13. Notice that the Wand used starts to recharge, while the other does not.

Currently condensing upgrade in the Golden Scroll works to recharge the last hotbar wand, used to cast a spell after the Condensing upgrade was added to the Golden Scroll (as long as it remains on the hotbar).

commented

This issue is potentially a duplicate of one of the following issues:

  • [#202] [Bug] Words of Unbinding randomly removes upgrade while holding a off-hand upgrade scroll (53% match)