Ancient Spellcraft

Ancient Spellcraft

6M Downloads

[Bug] Battlemage Runewords may be accessible by non-battlemage NPC Wizards

KnightCa opened this issue ยท 0 comments

commented

Is there an existing issue for this?

  • I have searched the existing issues

Observed behaviour

Can non-Battlemage NPCs be assigned Battlemage runewords by the mob generator that have the spell json listed NPC as True (example Runeword: Endure)?

I havent yet seen them cast, just noticed them set to be castable by NPC Wizards on the assets/spells config section.

This would either cause a issue in the non-Battlemage caster being assigned a spell they can't cast or be a issue thematically in them casting Runeword spells without Battlemage armor.

ie "If I want battlemages to use the runewords and keep it enabled for npcs in the json, I'll have to also override a method in those spells' java class file to only allow them for battlemage NPCs."

Expected behaviour

While NPC Battlemages should be able to get access to certain Runewords, non-Battlemage NPC's should not be assigned Runewords.

Steps to reproduce

There isn't a current way to assign Runewords to NPC casters (Battlemage or Wizard) to test this with, so it would need to be checked in the code.

Crashlog

No response

Environment (Singleplayer/Server, etc.)

Not sure

Mod version

1.5.11-PreRelease-54bfadc

Forge version

1.12.2-forge-14.23.5.2860

Other mods

No response