Ancient Warfare 2

Ancient Warfare 2

6M Downloads

Two Config Files For AncientWarfareVehicle on MacOS

bbharier opened this issue ยท 0 comments

commented

Context Environment

Minecraft version: 1.12.2

Ancient Warfare 2 version: ancientwarfare-1.12.2-2.7.0.1032.jar

Minecraft Forge version: 14.23.52854

Expected Behavior

There should be one config file for the AncientWarfareVehicle module, located at this path:
config/ancientwarfare/AncientWarfareVehicle.cfg

Current Behavior

Because of the way the file path is specified in code, this config file uses '\' (from windows?) in the file path, putting it in an odd location:
image

Notice that the file path is being specified in two ways, so at some point a file in the correct location is created as well.

I'm not 100% sure this is a windows/mac thing, or if this would be an issue on both operating systems. Seems strange that this is the only file this occurs on. The other config files go to the right place.

Steps to Reproduce

  1. Run the game from a fresh install on macOS. (Maybe also happens on windows with a fresh install, but I don't have a machine right now to test it.)

Possible Solution

It appears that the file name is manually overridden to "ancientwarfare\AncientWarfareVehicle" on this line:

@Config(modid = AncientWarfareVehicles.MOD_ID, name = "ancientwarfare\\AncientWarfareVehicle")

The exact file name appears to be generated automatically (using the modid provided) in the parent class for the other modules' config classes such as Automation or Structures. Notice they don't declare an override for the name variable:

public class AWAutomationStatics extends ModConfiguration {

public class AWStructureStatics extends ModConfiguration {

Not sure. Maybe there's a reason it needed to be set that way for the Vehicle module. Not familiar with enough of the codebase. The extra file is wigging out source control on my machine. Not a huge deal as I know you're mainly targeting windows, but it seems like it might be an easy fix since all the other config file paths work correctly.