Ancient Warfare 2

Ancient Warfare 2

6M Downloads

Lag and Client Disconnect while placing Windmill blocks.

aetherpirate opened this issue ยท 4 comments

commented

Running Thermos 1.7.10-1614-56

ancientwarfare-2.4.115-beta-MC1.7.10-FULL

Warmroast capture:
warmroast

latest server log:

latest.txt

As soon as I place another windmill block down, I timeout about 5 seconds later. When I re-join, it does not show that I placed anything. * If I place blocks slowly, I can gradually add to it. It still times out, but some of new blocks are present upon re-logging in.*

If I do not attempt to build it, I can play normally.

I am trying to make the max size of 17 x 17

Oddly, this issue did not begin right away, it was only after the incomplete windmill exceeded a certain size.

I noticed I cannot remove blocks either.

commented

How do I get ahold of this reverted code?

commented

Yup, I reported this when there was a major performance improvement to the windmill code. See my comment here: b0d2f8e#diff-c01118381cdf29002d76ac90e92c5665R78

GotoLink assured me though that there's nothing technically wrong, even though it's clearly getting a recursive loop somehow. I tried to fix it but it's beyond me... however I was getting the problem during superflat world generation, you have shared how it can be reproduced during construction. So maybe I will take another look at this and try to fix.

commented

There is nothing wrong about recursive pattern. Any decent computer can do hundreds of recursion steps.
I don't know why your computers can't. I'll revert to a for loop for you.

commented

Just tested your change, seems to have fixed it. Thanks!