Ancient Warfare 2

Ancient Warfare 2

6M Downloads

JustEnoughIDs is making the Lightly and Highly enchanted upgrade tools uncraftable

jinkhya opened this issue ยท 1 comments

commented

Hello,

After narrowing down wich mod was preventing the craft of those 2 items in my modpack, I found out it is no longer craftable when JEIDs is present. Having those 2 mods is enough to break the recipe (the result doesn't show up anymore)

If you want to reproduce the issue :
ancientwarfare-1.12.2-2.7.0.574.jar
CodeChickenLib-1.12.2-3.2.2.353-universal.jar
JustEnoughIDs-1.0.2-26.jar

Thannks !

commented

So, the reason these don't work with just enough items is that JEIDs changes data type of enchantements from short to integer, which in turn changes the data type of nbt data that's stored on enchanted books.
And the actual issue is that while recipe looks for id of type short in the nbt, the enchanged books have id of type integer.

And I don't really see a good way of adjusting the code to work with JEIDs other than hacking something specific for enchanted books in code that's generic for any kind of nbt or by adding two more recipes with different nbt data specifically because of JEIDs.

I don't like either of those and really feel that it's probably better for players to just add the recipes themselves if they need to or just cheat these in.

I will leave this around in case i come up with something that will work better, but most probably will just close.