Fluid block code needs updating (?)
PetasiGit opened this issue ยท 4 comments
Note: this affects all Betweenlands liquids.
Versions
Betweenlands version:
3.3.0 dev-659
Forge version:
Forge 1.12.2-14.23.1.2606
Singleplayer or Multiplayer:
Singleplayer.
Installed mods:
Appleskin 1.12.21.0.9
B.A.S.E 1.12.2-3.5.1
Better Fps 1.4.8
Better Placement 1.0.0-1
Client Tweaks 3.1.2
Clumps 3.0.0
FoamFix 1.12.2-0.9.0-Anarchy
Friendly Fire 1.5.8
Waila/Hwyla 1.8.23
InventoryTweaks-1.64-dev
Keyboard Wizard 1.12.2-1.5.3-b1
Macro Key 1.1.6.3
Mouse Tweaks 2.8
Nature's Compass 1.5.1
Ninja's Mods 1.12
Optifine 1.12.2 C8
StepUp 4.0-mc1.12
SwingThroughGrass 1.12.2-1.2.3
TapeMouse 1.1.3.17
Texture Fix 4.0
The Betweenlands 3.3.0 dev-659
XYZing 1.0
Description of the problem
How to reproduce:
Here I've made three 3x3 cubes with a hole in the top of each. The left one has swamp water,
the right one has vanilla water, and the middle one is empty.
I've now punched a hole in the side of each and let the water flow down.
After placing a block to obstruct the flow and waiting a bit, this is the result. As you can see, the betweenlands water is still somehow flowing, even though it's blocked off. The vanilla water is how it should behave.
Expected result:
For the water flow to be cut off.
Actual result:
It still was somehow flowing.
Seems to be a bug in net.minecraftforge.fluids.BlockFluidClassic or net.minecraftforge.fluids.BlockFluidBase
There is a Forge PR pending that should fix this if/when it is accepted: MinecraftForge/MinecraftForge#4763
It's not really a severe bug so I'll probably just wait for it to be fixed in Forge.