Animania Cats & Dogs

Animania Cats & Dogs

454k Downloads

Animania is not compatible with Industrial Foregoing's Animal Grower or Animal Feeder

katubug opened this issue · 6 comments

commented

Expected Behavior

I expected the Animal Grower to affect baby animals from Animania (it works on vanilla and other modded animals). I expected the Animal Feeder to keep the animals fed (and allow them to breed).

Actual Behavior

Neither machine has any effect on the animals.

Steps to Reproduce

  1. With both Animania and Industrial Foregoing installed, start game.
  2. Place any Animania animal within the working radius of the Animal Feeder, they will not be fed.
  3. Place any juvenile Animania animal within the working radius of the Animal Grower, it will not affect their growth speed.

Version of Minecraft, version of Animania, Single Player or Server

1.12.2
animania-1.12.2-1.6.2
CraftStudioAPI-universal-1.0.1.95-mc1.12-alpha
industrialforegoing-1.12.2-1.12.12-236
forge-1.12.2-14.23.5.2838-universal

commented

Even though this issue was marked as added in next release animania animals still don't work properly with foregoing.
animania-1.12.2-1.7.2
industrialforegoing-1.12.2-1.12.13-237

Animal Feeder:
Pigs, Cows and Horses are bottomless black holes. The feeder is constantly pumping them full, hearts are flying but there hasn't been a single baby born.
Chickens refuse seeds from the feeder and complain about hunger
Sheep at least breed but still require way more food than they should.

Animal Grower:
Doesn't seem to work at all. All baby animals are hungry and if enabled starve to death long before growing to adulthood.

commented

Thanks for the heads up. I'll open another request on foregoing.

Update: Issue on Industrial Foregoing: InnovativeOnlineIndustries/Industrial-Foregoing#616

commented

Well, I only added functionality for the animal grower (I made the animals grow up quicker, but not be fed. That was a bit of an oversight) I‘ll have to look into the other machines though.

commented

Am I assuming correctly that the animal feeder is also supposed to breed the animals? Because, with what Industrial Foregoing currently has in their code, this will never be possible for animania animals, unless they change their code.
This is the code that I'm talking about:
https://github.com/InnovativeOnlineIndustries/Industrial-Foregoing/blob/master/src/main/java/com/buuz135/industrial/tile/agriculture/AnimalStockIncreaserTile.java#L79-L99

Animania Animals don't have the same class and are still able to breed, so their class check would always fail. We also handle breeding differently, not using setInLove. If you really want compat for the animal feeder, you need to mention this to them.

commented

It's incompatibility issue. Wait for the devs. I think there's some real-life issue they are encountering

commented

I wanted to add on to this that I think chickens do seem to be fed correctly with the feeder, although they do not seem to breed as a result. It has been a while since I tested, however. The other issues remain the same.