Animania Cats & Dogs

Animania Cats & Dogs

454k Downloads

Mob is trying to access an invalid trough, throws NPE

NotMyWing opened this issue ยท 2 comments

commented

Expected Behavior

The server should not crash. :p

return this.getTrough().canConsume(fooditems, fluid);

This line, among several other lines, should check if getTrough() returned a valid tile-entity.

Actual Behavior

A mob crashes the server by finding an invisiblock that has no paired trough block.

Steps to Reproduce

...happen to break a Trough and leave its paired invisible block behind?

Version of Minecraft, version of Animania, Single Player or Server

Minecraft 1.12.2, Animania 1.7.2, server.

Crashlog

crash-2019-10-08_23.50.32-server.txt

Thanks!

commented

I was able to recreate this a few times. It seems to be due to the carry-on mod incorrectly picking up empty troughs. It creates an image of wheat, calls the item in your hand "air" and when you place it back down it creates an invisible entity with collision. When a nearby animal comes looking for the invisible trough's contents it seems to crashes. ( I think )

crash-2019-10-22_09.41.35-server.txt
crash-2019-10-22_09.42.37-server.txt
crash-2019-10-22_10.09.38-server.txt
image

commented

image