Render viewing the atlas in third-person
Lucipo opened this issue · 6 comments
Describe the bug
When looking at a held atlas, a third-person render is not shown. This is more of a suggestion because some mods like a first/third-person mod or other players in multiplayer want/need this feature.
(https://www.curseforge.com/minecraft/mc-mods/first-person-model)
OR compatibility with a third-person animation with https://www.curseforge.com/minecraft/mc-mods/not-enough-animations installed would also be a good option since it also adds third-person map animations already.
To Reproduce
Hold an atlas
Go in third person
It only renders the item :(
On Fabric, all latest versions always
Additional context
This is a lot more of a suggestion than a bug report but I think this will fit nicely with other mods that one may have in a modpack or for a little bit fancier gameplay with friends or in third-person.
And it could always be a config option on/off by default.
https://github.com/AntiqueAtlasTeam/AntiqueAtlas/blob/b8ac09c5f739e6055108f823e76bcfa0d2d478c9/src/main/java/hunternif/mc/impl/atlas/mixin/HeldItemRendererMixin.java Probably only will need some modifications (from?) here. I'll take a look at it when I have time.
Got around to look into it.
Still needs some tweaking with orientations and the big version when holding it with two hands still looks really janky. Also, it would require to lock this behind having Not enough animations installed(or copy mixins/logic with the arm transforms into this mod). One last issue: The textures are rendered with the Text RenderLayer which has culling active, causing the entire thing to be invisible from behind. For the vanilla maps I used access wideners and created a No Cull Text RenderLayer, not sure how to handle this here.
