Apotheosis

Apotheosis

Mods
89M Downloads

[Suggestion] Add item tags `#apotheosis:loot_category/{category_name}` for better mod compatibility

YocyCraft opened this issue ยท 1 comments

commented

Currently, Apotheosis check "decorative" equipable items by hardcoding;
LootCategory.java#L187

    private static Predicate<ItemStack> armorSlot(EquipmentSlot slot) {
        return stack -> {
            // Check for vanilla decorative equipable items
            if (stack.is(Items.CARVED_PUMPKIN) || 
                stack.getItem() instanceof BlockItem bi && bi.getBlock() instanceof AbstractSkullBlock) 
                return false;

            EquipmentSlot itemSlot = stack.getEquipmentSlot();
            if (itemSlot == null) {
                Equipable equipable = Equipable.get(stack);
                if (equipable != null) {
                    itemSlot = equipable.getEquipmentSlot();
                }
            }

            return itemSlot == slot;
        };
    }

However, some decorative items added by other mods cannot be detected in this way. If there are tags like #apotheosis:loot_category/{category_name} then mod authors can set loot categories in their mod, which will be better than let every player change config manually.

commented

a71ed39