Apotheosis

Hi hi, as title said. Most items cant be pulled if they have an affix, some can be pulled but only after equipping them, some just cannot be pulled no matter what I do. Ill share this issue I opened in the integrated Terminals mod which has all the investigation up to now, but was closed because the author thought it was about silent gear (which shows similar behavior)

CyclopsMC/IntegratedTerminals#152

There you can find tons of screenshots and data dumps of items and how they behave

@raoulvdberge

Hm, I might have some idea. I previously had a conversation about this with @raoulvdberge for a similar issue with RS, but we were unable to come to any conclusions. Upon retrospection, the culprit is probably this logic here:

Apotheosis/src/main/java/dev/shadowsoffire/apotheosis/mixin/ItemStackMixin.java

Lines 22 to 29 in 3137213

    
           if (ths.has(Components.AFFIX_NAME)) { 
        
               try { 
        
                   Component component = AffixHelper.getName(ths); 
        
                   if (component.getContents() instanceof TranslatableContents tContents) { 
        
                       int idx = "misc.apotheosis.affix_name.four".equals(tContents.getKey()) ? 2 : 1; 
        
                       tContents.getArgs()[idx] = cir.getReturnValue(); 
        
                       cir.setReturnValue(component); 
        
                   }

This modifies the value of the AFFIX_NAME data component, and it is likely only called on the client, which may incur a C/S desync of the value of this component. That would be an issue when the component is sent back to the server by ID.

@Shadows-of-Fire

@Shadows-of-Fire Has this potential fix been released in an Apotheosis version? I can redirect testers to this to see if it's fixed now.

@raoulvdberge

@raoulvdberge Not in a release version, but I published a beta to my maven here

Unfortunately did not seem to help.

I tried it as well, ATM10 v2.33 with RS2 MS4.13. The odd thing for me is that one single apoth axe is actually ok. As far as I can see no other apoth item works.

If yes, in which build can we try this?

@Shadows-of-Fire

@Shadows-of-Fire Did you make another change? Can we retry this?

	if (ths.has(Components.AFFIX_NAME)) {
	try {
	Component component = AffixHelper.getName(ths);
	if (component.getContents() instanceof TranslatableContents tContents) {
	int idx = "misc.apotheosis.affix_name.four".equals(tContents.getKey()) ? 2 : 1;
	tContents.getArgs()[idx] = cir.getReturnValue();
	cir.setReturnValue(component);
	}

Share to