Apotheosis

Hello, I'm opening this issue due to an incompatibility with a feature (Ingredient deduplication) on my mod (AllTheLeaks) which relies on stacks from Ingredients not being modified.

This recipeInputs is storing itemstacks from ingredient without making a copy of it so it can safely be modified later on L61

Apotheosis/src/main/java/dev/shadowsoffire/apotheosis/compat/jei/PotionCharmExtension.java

Lines 51 to 54 in 731df6c

    
           List<List<ItemStack>> recipeInputs = recipeHolder.value().getIngredients().stream() 
        
               .map(Ingredient::getItems) 
        
               .map(Arrays::asList) 
        
               .collect(Collectors.toCollection(ArrayList::new));

Apotheosis/src/main/java/dev/shadowsoffire/apotheosis/compat/jei/PotionCharmExtension.java

Line 61 in 731df6c

s.set(DataComponents.POTION_CONTENTS, new PotionContents(potion));

This is already being patched on my mod but only for versions up to latest (8.4.0), would be great if this change could be incorporated on main mod.
If you find this change not needed or unnecessary upstream let me know so I can remove the version upper bound restriction of the patch.

	List<List<ItemStack>> recipeInputs = recipeHolder.value().getIngredients().stream()
	.map(Ingredient::getItems)
	.map(Arrays::asList)
	.collect(Collectors.toCollection(ArrayList::new));

Share to