Commit b6466/v4.5.0 Resolves a serious bug
gattsuru opened this issue ยท 1 comments
Would it be possible to get this (and matching Placebo v4.4.2) published to CurseForge?
Specifically, the update to EnchModuleClient.
This came to my attention as a Minecolonies bug in Life In The Village 2, where a block from Farmer's Delight depends on Tag-related information, while the tooltip event is called on remote clients earlier than the Tags are populated. These two mods (+ Placebo) alone will show the critical exception, included as an attached log: see the line "[shadows.apotheosis.ench.EnchModuleClient:tooltips:48]: java.lang.IllegalStateException: Tag farmersdelight:tray_heat_sources used before it was bound" for the relevant callstack.
On its own, this wouldn't be that big of a deal; another tooltip event will be along shortly. However, Forge appears to allow this to bubble fairly high up the call stack; an unhandled exception here effects not only other mods subscribed to the tooltip event, but also some unrelated event calls, including the initial RecipesUpdatedEvent from a connecting remote client. For Minecolonies, that prevent the client from loading all furnace recipes until another RecipesUpdatedEvent occurs (which generally doesn't happen), and has significant downstream effects related to item filter GUI selections.
Apotheosis 4.5.0 + Placebo 4.4.2 self-built is tested to resolve the problem. Sorry for the github issue, but didn't want to ping you out of the blue on the Forge Discord.
