Compatibility issue with PneumaticCraft mod 1.16
Jophbot opened this issue ยท 2 comments
issue unresolvable from pnc side, figured I'd drop it here for you folks to take a look at:
TeamPneumatic/pnc-repressurized#966
Describe the bug
the spawner agitator appears to permanently set the player distance to -1 which would not be an issue except for in packs where other mods like apotheosis allows for spawners to be silk touch broken. This allows repeated application of the same agitator to set all spawners to -1 player distance permanently.
How to reproduce the bug
place a spawner. Apply agitator. Break spawner (with silk touch + apotheosis). Spawner now has player range value permanently set to -1
Expected behavior
player range value at agitator application is reapplied when agitator is removed.
Additional details
No response
Which Minecraft version are you using?
1.16
From PNC:
It actually sets the activation range to Integer.MAX_VALUE, but that's by the by.
The agitator does actually reset the range to 16 when it's broken, i.e. removed from the spawner. However that might not apply if the spawner itself is broken while an agitator is present, though I'll need to verify that. If that's the case, it should be easy enough to fix.
As a workaround, removing the agitator before breaking the spawner should work (although I appreciate that players might choose not to do that...)
Having looked into this more, I'm not sure there's much I can do about this. By the time the Spawner Agitator finds out that the spawner has been broken, it's too late for it to reset it (because the underlying block entity is already gone).
The only solution here is for Apotheosis to explicitly reset the activation range when the spawner is broken, sorry.