Apotheosis

Apotheosis

78M Downloads

Compatibility Breaking @ModifyConstant in AnvilMenuMixin

RaymondBlaze opened this issue ยท 0 comments

commented

Hi there!
I'm making compat for my mod and Apotheosis and encountered some unfixable problem as what mentioned in the title ;(
Version: 1.18.1 and 1.18.2, as I'm currently working on this 2 versions (It would be better if the fix could also be done on other versions though).
Problem: Apotheosis's AnvilMenuMixin and mine AnvilMenuMixin are both using @ModifyConstant for method AnvilMenu#createResult, which is a Redirector. As Apotheosis is not using constant field to restrict the behavior of @ModifyConstant, all constants in that method will be redirected by Apotheosis, leaving no space for me to do my work.
Possible Fix: Simply adding constant field to the @ModifyConstant annotation with value @Constant(intValue = 40) to restrict the constants affected by the redirector should fix the conflict. Btw, I also noticed that Apotheosis has the compatibilityLevel in apotheosis.mixin.json with the value of JAVA_8, would be better if updated to JAVA_17 :)