Hi i've got a trio of server crashes from the ATM 7B server,
pack version 0.4.27
Apotheosis version 1.18.2-5.5.1
Placebo-1.18.2-6.6.1
EvilCraft-1.18.2-1.2.6
Seems to be similar to #623

crash-2022-08-22_10.55.03-server.txt
crash-2022-08-22_15.22.37-server.txt
crash-2022-08-22_15.39.36-server.txt

@Shadows-of-Fire AFAIK EvilCraft is not doing anything special related to attributes (developer here): https://github.com/CyclopsMC/EvilCraft/blob/master-1.19/src/main/java/org/cyclops/evilcraft/entity/monster/EntityVengeanceSpirit.java#L158-L166

Are you sure your handler is considering all entities?

@rubensworks Currently these attributes are applied to all living entities via EntityAttributeModificationEvent https://github.com/Shadows-of-Fire/Apotheosis/blob/1.18/src/main/java/shadows/apotheosis/adventure/AdventureModule.java#L179
Previously they were applied via mixin here

The crash was still present with the mixin, even though the mixin should be more broad, as I figured ALL living entities would be using LivingEntity.createLivingAttributes as their attribute supplier base.

How are your entity attribute suppliers built?

Your current event handler looks correct to me as well.

I'm using the same event to register attributes: https://github.com/CyclopsMC/EvilCraft/blob/master-1.19/src/main/java/org/cyclops/evilcraft/entity/monster/EntityVengeanceSpiritConfig.java#L81-L99
So the event does work, so the only potential problem I see atm is that my EC's entity types could not present in the event's getTypes result (not sure though).

Potentially. Since it's a mod bus event - but that wouldn't explain why the mixin variant wouldn't work either.

Oh wait a second! You aren't supposed to use the modification event for your own entities, You're supposed to use the EntityAttributeCreationEvent, hence why your types aren't showing in this event for me.

Evilcraft must be doing something weirdly nonstandard with their entity attributes, as I have a handler adding these to all entities.

cross posted to them CyclopsMC/EvilCraft#936

Oohh, I didn't even know about that event. That makes sense, will fix it soon on my end.
Thanks a lot for the help @Shadows-of-Fire ! :-)