Use tags to control critical and life steal
ch1335 opened this issue ยท 2 comments
I hope to use damage tags to control which damage can be or can not be critical hit or which damage can or can not do life steal.Because sometimes I don't want certain damages to be critical hits or can do life steal
Crit is already handled by apothic_attributes:cannot_critically_strike.
I'm not sure Life Steal requires an explicit additional tag. It is already controlled by two tags. That is, life steal only applies to damage types which pass the following checks:
public static boolean isPhysicalDamage(DamageSource src) {
return src.is(Tags.DamageTypes.IS_PHYSICAL) && !src.is(ALObjects.Tags.IS_NON_PHYSICAL);
}Those tags being minecraft:is_physical and apothic_attributes:is_non_physical.