Apothic Curios

Apothic Curios

Mods
1M Downloads

COmpatibility issue with apotheosis 7.3.3

glea94 opened this issue · 2 comments

commented

Hi i just came from Apotheosis issue report about gem socketed in rings and he told me that i have to go there cause it's a incompatible issue with your last mod from february. Apotheosis is up to date today.
this is the log i provided and told me to report the issue to you. I cannot play with your mod actually and let on stand by😔
Thank you
The log start when i enter the map and put the mouse cursor on the socketed ring and the game ctd or freeze to be killed.
https://mclo.gs/aPNysQk

commented

the required change btw

Index: src/main/java/daripher/apothiccurios/ApothicCuriosMod.java
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/src/main/java/daripher/apothiccurios/ApothicCuriosMod.java b/src/main/java/daripher/apothiccurios/ApothicCuriosMod.java
--- a/src/main/java/daripher/apothiccurios/ApothicCuriosMod.java	(revision addc37bbb65afddee9f779f7c7b5c954d0940a77)
+++ b/src/main/java/daripher/apothiccurios/ApothicCuriosMod.java	(date 1710747323323)
@@ -136,7 +136,7 @@
   }
 
   private void removeTooltip(ItemTooltipEvent event, GemInstance gem, ItemStack stack) {
-    Optional<GemBonus> bonus = gem.gem().getBonus(LootCategory.forItem(stack));
+    Optional<GemBonus> bonus = gem.gem().getBonus(LootCategory.forItem(stack), gem.rarity());
     if (bonus.isEmpty()) return;
     getGemModifiersTooltips(gem, bonus.get()).forEach(c -> removeTooltip(event, c));
     removeTooltip(event, bonus.get().getSocketBonusTooltip(gem.gemStack(), gem.rarity()));
commented

Because the developer of this mod is seemingly completely inactive, and hasn't merged the pull request that has been open for weeks which fixes this exact issue, I went and made a mod with a single mixin to redirect the method call to the correct one, thus fixing the mod.

I released that mixin mod on GitHub here: https://github.com/NyanMC/StableSocketing/releases/tag/1.0.0

Once CurseForge approves it, it will also be there.

  • 👍1