AppleCore

AppleCore

56M Downloads

AppleCore doesn't trigger an error when used with the wrong MC version

Syndaryl opened this issue ยท 8 comments

commented

Which is causing errors and threatening messages in the Forge log...

commented

Well first of all Apple Core is not released for 1.11.2 just yet.
And yes Apple Cores ID for 1.11.2 is lowercased https://github.com/squeek502/AppleCore/blob/1.11.2/java/squeek/applecore/ModInfo.java#L5.

commented

OK, I'm a little confused since I got it off Curseforge yesterday (along with Appleskin). Looking at the JAR again it's the 1.10.2 not 1.11.2 - but I have no idea why forge wouldn't just reject it for being the wrong version entirely. shrug Oh well, sorry for bothering you.

commented

Yeah, it might be a good idea for us to use acceptedMinecraftVersions to make Forge trigger an error on incompatible MC versions. Even weirder is that the core mod part of AppleCore is locked to the MC version and definitely wouldn't have loaded if you tried to use the 1.10.2 version with 1.11.2.

Re-opening for now, will close again when acceptedMinecraftVersions gets set.

commented

Sounds good for me.

commented

Also worth mentioning just in case you weren't aware that AppleSkin doesn't depend on AppleCore, it's completely standalone.

commented

I didn't realize that yesterday, but I put two and two together finally today :)

commented
commented

Most excellent!