1.20.5 Support
sky-is-winning opened this issue · 11 comments
The Fabric 1.20.3 version which worked on both 1.20.3 and 1.20.4 crashes on load in 1.20.5.
Created new branches for 1.20.5, no updates made yet though:
- https://github.com/squeek502/AppleSkin/tree/1.20.5-neoforge
- https://github.com/squeek502/AppleSkin/tree/1.20.5-fabric
They are separate from the 1.20.x branch since it seems possible that we'll want to maintain 1.20.1, 1.20.4, and 1.20.5 versions separately.
Just want to note that for Fabric, the 1.20.5 branch should be based on https://github.com/squeek502/AppleSkin/tree/24w14potato-fabric
It looks like Neoforge adds a lot of new layers that Vanilla doesn't have:
https://github.com/neoforged/NeoForge/blob/916bfcbc540abf1a1b1ba4162905a28aa754894d/patches/net/minecraft/client/gui/Gui.java.patch
So I don't think a change is needed for Fabric. However, the Fabric mixin can probably be simplified, since now there's a renderFood method in InGameHud that we can inject into instead.
EDIT: Made the simplification in the Fabric branch: a7830bb
Doing a bit of work on this, I think this might end up warranting bumping the version to 3.0.0, since FoodComponent should probably change how the API works (I'm thinking we should delete FoodValues and use FoodComponent instead).
Committed my Fabric port here: 15b9ff0
Need to test the API changes still. I'm also unable to get a Neoforge environment working, so that might need to wait.
forge neoforge the gui layer is changed, i needs reimplements it with new api.
By the way, I'm not planning on supporting Forge anymore, so we only need to update for Neoforge.