[1.12.2] Modified vanilla fish items not displaying correctly
luke-bravenboer opened this issue · 4 comments
AppleSkin isn't reflecting the changes to the foodValue / saturationModifier for any of the <minecraft:fish:*> or <minecraft:cooked_fish:*>.
(Note: strictly for Minecraft 1.12, before the vanilla fish items were split into separate IDs)
I've been testing Mrbysco's latest update to FoodTweaker, which added support for modifying food items with metadata (such as fish / golden apple variants).
I'm using a simple test script for FoodTweaker which modifies a list of vanilla foods to give maximum food and saturation values so that I can quickly confirm that changes have been applied correctly.
(see the script here for more info: https://paste.dimdev.org/raruxadogi.xml)
As demonstrated in this screenshot, it's working as intended for most foods, including those with metadata such as the 'enchanted' golden apple:
However, it's not displaying the updated information for the any of the 4x minecraft:fish or the 2x minecraft:cooked_fish:
...Even though eating one does indeed restore my hunger bar to full, as demonstrated in the comparison with the next screenshot:
~
Versions:
- Minecraft 1.12.2
- Forge 14.23.5.2847
- AppleSkin-mc1.12-1.0.9
- CraftTweaker2-1.12-4.1.20
- FoodTweaker-1.1.1
Original issue on FoodTweaker's side: Mrbysco/FoodTweaker#2
For the FoodTweaker developer's explanation of why this problem exists, see this comment:
Mrbysco/FoodTweaker#2 (comment)
This type of incompatibility is what AppleCore was made to prevent. FoodTweaker would need to stop overwriting FoodStats (which would cause problems with any other mod that overwrites FoodStats [hence the need for something like AppleCore]) and use AppleCore's API to modify the values of the foods instead (or, alternatively, only use the AppleCore stuff if it's present if they don't want to add a hard dependency).
There's also Hunger Tweaker which is an AppleCore-compatible version of the same type of mod as FoodTweaker.
