encoded pattern can't display its output in ME interface with DragonAPI
Deachearth opened this issue · 18 comments
Description
Encoded Pattern not show synthetic items.
Not shown on the Interface Terminal.
The other is the same, such as ME Interface, Terminal.
What should I do?
Environment
├─mods
│ │ appliedenergistics2-rv3-beta-6.jar
│ │
│ └─1.7.10
│ DragonAPI 1.7.10 V16d.jar
- Minecraft Version: 1.7.10
- AE2 Version: rv3-beta-6
- Forge Version: 10.13.4.1614
the image link is broken and your issue description does not fit in context with the headline
also what do you mean by "synthetic items" ?
what is "Not shown on the Interface Terminal." the pattern or the "synthetic items" ... i suspect you mean the icon of the item saying "craft" instead of the number?
Craft icon not show icon.
After viewing the code found that DragonAPI 1.7.10 V16d.jar and appliedenergistics2-rv3-beta-6.jar at the same time the problem makes the icon is not displayed.
What should I do?
Ah, OK. Now this is familiar.
Normally when you create a crafting pattern and stick it into (for example) a molecular assembler, you see the icon for the item that will be crafted, not the icon of the blank pattern.
With DragonAPI installed, all you see is the blank pattern icon, although I think pressing shift would work to display the "crafting result" icon instead.
I'm not aware of any fix.
Ohhh...I've had similar issues with the Silicon Press textures being filled in and all I could see was the press outline, but when I clicked them or held "Shift", I could see the inside shape. I can't remember when or what caused this, but I remember seeing such things before.
@yueh can you have at least a glance on this? i won't close it as such an API conflict would probably be not solved when all the changes get backported to rv3, this would then be a true rv3 issue that is not present in rv4
@CraftMinerKyle @GuntherDW Yes, this question.
I add the code to use a IClassTransformer reload the AE2 api bytecode before it is loaded by the classloader. You can try it. The CI build version can be find there
This is caused by DragonAPI ASM'ing the same place as AE2 does. I reported this bug in Reika's forumtopic way back in 2014 even.
Let me see if I can get a link
EDIT: That wasn't so hard -> http://www.minecraftforum.net/forums/mapping-and-modding/minecraft-mods/1291655-reikas-mods-tech-worldgen-civilization-and-more?comment=15431
@xsun2001 Thank you.
But the problem still exists. The craft icon is not shown.
You can try adding DragonAPI 1.7.10 V16d.jar and making Encode Pattern.
Ahh...I find the problem. DragonAPI and AE2 all want to ASM one method net.minecraft.client.gui.inventory.GuiContainer.func_146977_a. DragonAPI want to fire a event by ASMing. But I don't know what does AE2 want to do. I will check it more carefully. I believe I can balance the two mods' changes. By the way, my code can only recovery AE2's API, so it isn't useful for minecraft's code and make no influence to this issue.
That's what I (and Reika) indeed back in 2014 said in that topic I linked.
Reika wasn't willing to change or mod his code for compatibility with AE2.
(even though the mod kind of relies on it being installed a bit, or any other sort of auto-crafting mechanism).
It may be difficult to solve this issue. @GuntherDW I read the topic but to find my English is too bad to understand it completely. But now, we cannot let DragonAPI to change itself and the change of AE2 cannot be ignored. I think I have to find another way to do something on the bytecode.
So I never want anybody to change anything of Minecraft and Forge, which are instable enough.
Perhaps an AE2 and DragonAPI Addon Compatibility mod could be created just for this very purpose...
Test to see if DragonAPI is present, download compat resource, execute compat addon, continue life with one less problem!
Tell Reika to stop shipping the AE2 api. We explicitly told him to not do it, but he choose otherwise. So that is on him.
1.7.10 is unsupported. DragonAPI has always done extremely questionable things, there is nothing that can ve done.